Showing 19 of 53 total issues
Function parseData
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
protected function parseData($name, $value)
{
if (!empty($value)) {
if (preg_match('/.+(Datetime|Date)$/', $name)) {
// ISO 8601 Date
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method testCreateRecurringCustomerPayment
has 62 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testCreateRecurringCustomerPayment()
{
// Mock the payment
$paymentMock = $this->getPayment();
Function assertModel
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
protected function assertModel(ModelBase $model, $reference, array $mapping)
{
foreach ($mapping as $k => $v) {
$k = is_int($k) ? $v : $k; // Handle non-associative arrays
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getMultiPageRequestMock
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getMultiPageRequestMock(Mollie $api, $data, $endpoint)
{
// Epic math skills
$totalCount = count($data);
$dataPageOne = array_slice($data, 0, floor($totalCount / 2));
Method testCreateCustomerPayment
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testCreateCustomerPayment()
{
// Mock the payment
$paymentMock = $this->getPayment();
Method testCreatePayment
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testCreatePayment()
{
// Mock the payment
$paymentMock = $this->getPayment();
Method testCreateCustomerSubscription
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testCreateCustomerSubscription()
{
// Mock the subscription
$subscriptionMock = $this->getSubscription();
Method testCreateCustomerMandate
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testCreateCustomerMandate()
{
// Mock the mandate
$mandateMock = $this->getCustomerMandate();
Method parseData
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function parseData($name, $value)
{
if (!empty($value)) {
if (preg_match('/.+(Datetime|Date)$/', $name)) {
// ISO 8601 Date
Method update
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
{
// Check metadata type if given
if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
Function create
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function create($amount, $interval, $description, $times = null, array $opts = array())
{
// Check number of times
if (isset($times) && ($times < 1 || !is_numeric($times))) {
throw new \InvalidArgumentException("Invalid number of charges for this subscription. Please enter a number of 1 or more, or leave null for an ongoing subscription.");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function create($amount, $description, $redirectUrl, $metadata = null, array $opts = array())
Method createFirstRecurring
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function createFirstRecurring($amount, $description, $redirectUrl, $metadata = nul, array $opts = array())
Method create
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function create($amount, $description, $redirectUrl, $metadata = null, array $opts = array())
Method update
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
Method create
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function create($amount, $interval, $description, $times = null, array $opts = array())
Function getResourceID
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function getResourceID($resource, $type, &$property = null)
{
// Get short resource type class name (payment, customer...)
$name = strtolower(substr($type, strrpos($type, '\\') + 1));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $value;
Function update
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
{
// Check metadata type if given
if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"