CoCongV/sanic-restful

View on GitHub
sanic_restful/reqparse.py

Summary

Maintainability
F
3 days
Test Coverage

Function parse has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

    def parse(self, request, req_temp, bundle_errors=False):
        """Parses argument value(s) from the request, converting according to
        the argument's type.

        :param request: The flask request object to parse arguments from
Severity: Minor
Found in sanic_restful/reqparse.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File reqparse.py has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import collections
from copy import deepcopy
import decimal

from sanic.exceptions import abort, InvalidUsage
Severity: Minor
Found in sanic_restful/reqparse.py - About 3 hrs to fix

    Function source has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def source(self, request):
            """Pulls values off the request in the provided location
            if location is str:
                json -> dict
                form, args, file -> RequestParameters
    Severity: Minor
    Found in sanic_restful/reqparse.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 16 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self,
    Severity: Major
    Found in sanic_restful/reqparse.py - About 2 hrs to fix

      Function convert has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def convert(self, value, op):
              if self.location == "file":
                  return value
              if not value:
                  if self.nullable:
      Severity: Minor
      Found in sanic_restful/reqparse.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parse_args has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse_args(self, request: Request, strict=False):
              """Parse all arguments from the provided request and return the results
              as a Namespace
      
              :param strict: if req includes args not in parser,
      Severity: Minor
      Found in sanic_restful/reqparse.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if request.app.config.get("BUNDLE_ERRORS",
                                                        False) or bundle_errors:
                                  return self.handle_validation_error(
                                      request.app,
                                      ValueError("{0} is not a valid choice".format(
      Severity: Major
      Found in sanic_restful/reqparse.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if hasattr(self.choices, "__iter__"):
                                    self.choices = [choice.lower()
                                                    for choice in self.choices]
        
        
        Severity: Major
        Found in sanic_restful/reqparse.py - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                              return self.type(value, self.name)
          Severity: Major
          Found in sanic_restful/reqparse.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return results, _found
            Severity: Major
            Found in sanic_restful/reqparse.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return self.type(value)
              Severity: Major
              Found in sanic_restful/reqparse.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return results[0], _found
                Severity: Major
                Found in sanic_restful/reqparse.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return results, _found
                  Severity: Major
                  Found in sanic_restful/reqparse.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return self.type(str(value))
                    Severity: Major
                    Found in sanic_restful/reqparse.py - About 30 mins to fix

                      Function add_argument has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def add_argument(self, *args, **kwargs) -> None:
                              """Adds an argument to be parsed.
                      
                              Accepts either a single instance of Argument or arguments to be passed
                              into :class:`Argument`'s constructor.
                      Severity: Minor
                      Found in sanic_restful/reqparse.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      There are no issues that match your filters.

                      Category
                      Status