Sign upLogin

CocoaPods/CocoaPods

View on GitHub
Star
lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb

Summary

Maintainability
D
1 day
Test Coverage
B
86%

Method wire_test_native_target_app_host has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def wire_test_native_target_app_host(test_native_target, pod_target, pod_target_installation_results, project, metadata_cache, app_host_pod_target_label, app_host_target_label)
          if dependency_installation_result = pod_target_installation_results[app_host_pod_target_label]
            unless app_native_target = dependency_installation_result.app_host_target_labelled(app_host_target_label)
              raise Informative, "Did not find target with label #{app_host_target_label} in the set of targets installed for #{app_host_pod_target_label}."
            end
Severity: Minor
Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wire_app_native_targets has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def wire_app_native_targets(pod_target, installation_result, pod_target_installation_results, project, metadata_cache)
          installation_result.app_specs_by_native_target.each do |app_native_target, app_spec|
            resource_bundle_native_targets = installation_result.app_resource_bundle_targets[app_spec.name] || []
            resource_bundle_native_targets.each do |app_resource_bundle_target|
              app_native_target.add_dependency(app_resource_bundle_target)
Severity: Minor
Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wire_test_native_target_app_host has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def wire_test_native_target_app_host(test_native_target, pod_target, pod_target_installation_results, project, metadata_cache, app_host_pod_target_label, app_host_target_label)
          if dependency_installation_result = pod_target_installation_results[app_host_pod_target_label]
            unless app_native_target = dependency_installation_result.app_host_target_labelled(app_host_target_label)
              raise Informative, "Did not find target with label #{app_host_target_label} in the set of targets installed for #{app_host_pod_target_label}."
            end
Severity: Minor
Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 1 hr to fix

    Method wire_test_native_targets has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def wire_test_native_targets(pod_target, installation_result, pod_target_installation_results, project, metadata_cache)
          installation_result.test_specs_by_native_target.each do |test_native_target, test_spec|
            resource_bundle_native_targets = installation_result.test_resource_bundle_targets[test_spec.name] || []
            resource_bundle_native_targets.each do |test_resource_bundle_target|
              test_native_target.add_dependency(test_resource_bundle_target)
    Severity: Minor
    Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wire_app_native_targets has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def wire_app_native_targets(pod_target, installation_result, pod_target_installation_results, project, metadata_cache)
          installation_result.app_specs_by_native_target.each do |app_native_target, app_spec|
            resource_bundle_native_targets = installation_result.app_resource_bundle_targets[app_spec.name] || []
            resource_bundle_native_targets.each do |app_resource_bundle_target|
              app_native_target.add_dependency(app_resource_bundle_target)
    Severity: Minor
    Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 1 hr to fix

      Method wire_test_native_target_app_host has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def wire_test_native_target_app_host(test_native_target, pod_target, pod_target_installation_results, project, metadata_cache, app_host_pod_target_label, app_host_target_label)
      Severity: Major
      Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 50 mins to fix

        Method wire_target_dependencies has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def wire_target_dependencies(pod_target, native_target, project, pod_target_installation_results, metadata_cache)
        Severity: Minor
        Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 35 mins to fix

          Method wire_app_native_targets has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def wire_app_native_targets(pod_target, installation_result, pod_target_installation_results, project, metadata_cache)
          Severity: Minor
          Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 35 mins to fix

            Method wire_test_native_targets has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def wire_test_native_targets(pod_target, installation_result, pod_target_installation_results, project, metadata_cache)
            Severity: Minor
            Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 35 mins to fix

              Method install! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def install!
          # Wire up pod targets
          pod_target_installation_results.values.each do |pod_target_installation_result|
            pod_target = pod_target_installation_result.target
            native_target = pod_target_installation_result.native_target
              Severity: Minor
              Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method wire_target_dependencies has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def wire_target_dependencies(pod_target, native_target, project, pod_target_installation_results, metadata_cache)
          dependent_targets = pod_target.dependent_targets
          dependent_targets.each do |dependent_target|
            is_local = sandbox.local?(dependent_target.pod_name)
            if installation_result = pod_target_installation_results[dependent_target.name]
              Severity: Minor
              Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          test_dependent_targets.each do |test_dependent_target|
              is_local = sandbox.local?(test_dependent_target.pod_name)
              if dependency_installation_result = pod_target_installation_results[test_dependent_target.name]
                dependent_test_project = dependency_installation_result.native_target.project
                if dependent_test_project != project
              Severity: Major
              Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb and 1 other location - About 1 hr to fix
              lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb on lines 74..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        dependent_targets.each do |dependent_target|
            is_local = sandbox.local?(dependent_target.pod_name)
            if installation_result = pod_target_installation_results[dependent_target.name]
              dependent_project = installation_result.native_target.project
              if dependent_project != project
              Severity: Major
              Found in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb and 1 other location - About 1 hr to fix
              lib/cocoapods/installer/xcode/pods_project_generator/pod_target_dependency_installer.rb on lines 99..111

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status