CocoaPods/Molinillo

View on GitHub
lib/molinillo/dependency_graph.rb

Summary

Maintainability
A
3 hrs
Test Coverage
B
82%

Method == has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def ==(other)
      return false unless other
      return true if equal?(other)
      vertices.each do |name, vertex|
        other_vertex = other.vertex_named(name)
Severity: Minor
Found in lib/molinillo/dependency_graph.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method path has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def path(from, to)
      distances = Hash.new(vertices.size + 1)
      distances[from.name] = 0
      predecessors = {}
      each do |vertex|
Severity: Minor
Found in lib/molinillo/dependency_graph.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return false unless other_vertex.successors.to_set == vertex.successors.to_set
Severity: Major
Found in lib/molinillo/dependency_graph.rb - About 30 mins to fix

    Method to_dot has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_dot(options = {})
          edge_label = options.delete(:edge_label)
          raise ArgumentError, "Unknown options: #{options.keys}" unless options.empty?
    
          dot_vertices = []
    Severity: Minor
    Found in lib/molinillo/dependency_graph.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status