Sign upLogin

CocoaPods/cocoapods-trunk

View on GitHub
Star

Showing 4 of 4 total issues

Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

        def run
          me = json(request_path(:get, 'sessions', auth_headers))
          owner = json(request_path(:get, "owners/#{me['email']}"))
          UI.labeled 'Name', owner['name']
          UI.labeled 'Email', owner['email']
Severity: Minor
Found in lib/pod/command/trunk/me.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def run
          me = json(request_path(:get, 'sessions', auth_headers))
          owner = json(request_path(:get, "owners/#{me['email']}"))
          UI.labeled 'Name', owner['name']
          UI.labeled 'Email', owner['email']
Severity: Minor
Found in lib/pod/command/trunk/me.rb - About 1 hr to fix

    Method validate! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def validate!
          super
          unless token
            help! 'You need to run `pod trunk register` to register a session first.'
          end
    Severity: Minor
    Found in lib/pod/command/trunk/push.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method print_messages has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def print_messages(data_url, messages, spec = nil, action = nil)
        if verbose? || spec.nil?
          # Using UI.labeled here is dangerous, as it wraps the URL and indents
          # it, which breaks the URL when you try to copy-paste it.
          UI.puts "  - Data URL: #{data_url}"
    Severity: Minor
    Found in lib/pod/command/trunk.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language