Sign upLogin

CodeBrauer/PlaceIt

View on GitHub
Star

Showing 3 of 3 total issues

Function getImageScale has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getImageScale($x, $y, $longestLength, $allowDistort = false) {
        //Set the default NEW values to be the old, in case it doesn't even need scaling
        list($nx, $ny) = array($x, $y);
            if ($x > $y) {
                if ($longestLength > $x && !$allowDistort) {
Severity: Minor
Found in library/Helper.class.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convert2rgb has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static function convert2rgb($color_code)
    {
        if (preg_match('/(\d{1,3},\d{1,3},\d{1,3})/', $color_code)) {   // check for RGB
            $arr = explode(',', $color_code);
            return max($arr) > 255 ? false : $arr;
Severity: Minor
Found in library/Helper.class.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return array($nx, $ny);
Severity: Major
Found in library/Helper.class.php - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language