Sign upLogin

CodeTheChangeUBC/sasc

View on GitHub
Star

Showing 160 of 160 total issues

Avoid too many return statements within this function.
Open

    return res.status(201).send({success: "Successfully changed password."});
Severity: Major
Found in server/controllers/account.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return res.status(422).send({error: "Failed to change password."});
    Severity: Major
    Found in server/controllers/account.js - About 30 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      function mapDispatchToProps(dispatch) {
    return bindActionCreators(
        {
            signupUser: authActions.signupUser,
            addUser: userActions.addUser,
      Severity: Major
      Found in client/src/Containers/Register/index.js and 3 other locations - About 30 mins to fix
      client/src/Containers/Login/index.js on lines 90..99
      client/src/Containers/LoginCounsellor/index.js on lines 86..95
      client/src/Containers/PreChatSurvey/index.js on lines 115..124

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

          return res.status(201).send({success: "Successfully added or updated twilio account information."});
      Severity: Major
      Found in server/controllers/twilio.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return res.status(422).send({error: "Failed to encrypt password."});
        Severity: Major
        Found in server/controllers/account.js - About 30 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          function mapDispatchToProps(dispatch) {
    return bindActionCreators(
        {
            submitSurvey: userActions.submitSurvey,
            renderUserError: userActions.renderUserError,
          Severity: Major
          Found in client/src/Containers/PreChatSurvey/index.js and 3 other locations - About 30 mins to fix
          client/src/Containers/Login/index.js on lines 90..99
          client/src/Containers/LoginCounsellor/index.js on lines 86..95
          client/src/Containers/Register/index.js on lines 178..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                  return res.status(422).send({error: "Database "+role+" update error."});
          Severity: Major
          Found in server/controllers/account.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return res.status(422).send({error: "Failed to encrypt password."});
            Severity: Major
            Found in server/controllers/account.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return res.status(422).send({error: "Failed to change password."});
              Severity: Major
              Found in server/controllers/account.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return res.status(422).send({error: "Cannot create " + role + "because !results"});
                Severity: Major
                Found in server/controllers/authentication.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return res.status(201).send({success: "Successfully updated "+role+"."});
                  Severity: Major
                  Found in server/controllers/account.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return res.status(422).send({error: "Failed to update "+role+" account information."});
                    Severity: Major
                    Found in server/controllers/account.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return done(null, users[0]);
                      Severity: Major
                      Found in server/services/passport.js - About 30 mins to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        function mapDispatchToProps(dispatch) {
    return bindActionCreators(
        {
            signinCounsellor: authActions.signinCounsellor,
            addCounsellor: counsellorActions.addCounsellor,
                        Severity: Major
                        Found in client/src/Containers/LoginCounsellor/index.js and 3 other locations - About 30 mins to fix
                        client/src/Containers/Login/index.js on lines 90..99
                        client/src/Containers/PreChatSurvey/index.js on lines 115..124
                        client/src/Containers/Register/index.js on lines 178..187

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                        function mapDispatchToProps(dispatch) {
    return bindActionCreators(
        {
            signinUser: authActions.signinUser,
            addUser: userActions.addUser,
                        Severity: Major
                        Found in client/src/Containers/Login/index.js and 3 other locations - About 30 mins to fix
                        client/src/Containers/LoginCounsellor/index.js on lines 86..95
                        client/src/Containers/PreChatSurvey/index.js on lines 115..124
                        client/src/Containers/Register/index.js on lines 178..187

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function handleOnSubmit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            handleOnSubmit(ev) {
        ev.preventDefault();
        var ID;
        var fields;
        var validated = false;
                        Severity: Minor
                        Found in client/src/Containers/Account/index.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        exports.count = function(model) {    
    return new Promise(function(fulfill, reject) {
        db.get().query('SELECT COUNT(ID) AS count FROM '+model+';', function(err,results,fields) {            
            if (err) { reject(err); }
            if (results.length > 0) {
                        Severity: Minor
                        Found in server/models/abstract.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function handlePasswordChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            handlePasswordChange(ev) {
        ev.preventDefault();
        const { oldPassword, newPassword, newPasswordConfirm } = this.state;
        var validated = false;
        if (this.props.auth === "user") {
                        Severity: Minor
                        Found in client/src/Containers/PasswordChange/index.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function checkRoleAndGetInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        exports.checkRoleAndGetInfo = async function (req, res) {

    try {
        const tokenContents = jwt.decode(req.body.token, config.secret);
        const role = tokenContents.role;
                        Severity: Minor
                        Found in server/controllers/authentication.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function updateAccount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        exports.updateAccount = async function (role, model, user, id, req, res) {
    // Check entered password before updating user information
    var err, users, isMatch;
    [err, users] = await to(model.lookupById(id));
    if (err) {
                        Severity: Minor
                        Found in server/controllers/account.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language