Codeminer42/cm42-central

View on GitHub
app/models/activity.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for merge_story! is too high. [35.92/25]
Open

  def merge_story!(activity)
    return if subject_type != 'Story' # story only
    return if subject_id != activity.subject_id # only merge the exact same story change
    return if updated_at > activity.updated_at # only merge from future changes
    return if activity.subject_changes.blank?
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Complex method Activity#merge_story! (46.6)
Open

  def merge_story!(activity)
    return if subject_type != 'Story' # story only
    return if subject_id != activity.subject_id # only merge the exact same story change
    return if updated_at > activity.updated_at # only merge from future changes
    return if activity.subject_changes.blank?
Severity: Minor
Found in app/models/activity.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Cyclomatic complexity for merge_story! is too high. [8/6]
Open

  def merge_story!(activity)
    return if subject_type != 'Story' # story only
    return if subject_id != activity.subject_id # only merge the exact same story change
    return if updated_at > activity.updated_at # only merge from future changes
    return if activity.subject_changes.blank?
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Complex method Activity::fetch_polymorphic (37.7)
Open

  def self.fetch_polymorphic(ids, since)
    stories = where("subject_type in ('Project', 'Story')")
      .includes(:user, :subject)
      .projects(ids)
      .since(since).to_a
Severity: Minor
Found in app/models/activity.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Perceived complexity for merge_story! is too high. [9/8]
Open

  def merge_story!(activity)
    return if subject_type != 'Story' # story only
    return if subject_id != activity.subject_id # only merge the exact same story change
    return if updated_at > activity.updated_at # only merge from future changes
    return if activity.subject_changes.blank?
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method merge_story! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def merge_story!(activity)
    return if subject_type != 'Story' # story only
    return if subject_id != activity.subject_id # only merge the exact same story change
    return if updated_at > activity.updated_at # only merge from future changes
    return if activity.subject_changes.blank?
Severity: Minor
Found in app/models/activity.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Complex method Activity::grouped_activities (28.8)
Open

  def self.grouped_activities(allowed_projects, since)
    fetch_polymorphic(allowed_projects.pluck(:id), since).group_by do |activity|
      activity.created_at.beginning_of_day
    end.map do |date, activities|
      [
Severity: Minor
Found in app/models/activity.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Method fetch_polymorphic has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.fetch_polymorphic(ids, since)
    stories = where("subject_type in ('Project', 'Story')")
      .includes(:user, :subject)
      .projects(ids)
      .since(since).to_a
Severity: Minor
Found in app/models/activity.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Align .projects with where("subject_type in ('Project', 'Story')") on line 28.
Open

      .projects(ids)
Severity: Minor
Found in app/models/activity.rb by rubocop

Avoid multi-line chains of blocks.
Open

            end.map do |subject_type, activities|
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop checks for chaining of a block after another block that spans multiple lines.

Example:

Thread.list.find_all do |t|
  t.alive?
end.map do |t|
  t.object_id
end

Align .projects with where("subject_type in ('Note', 'Task')") on line 32.
Open

      .projects(ids)
Severity: Minor
Found in app/models/activity.rb by rubocop

Align .includes with where("subject_type in ('Project', 'Story')") on line 28.
Open

      .includes(:user, :subject)
Severity: Minor
Found in app/models/activity.rb by rubocop

Align .includes with where("subject_type in ('Note', 'Task')") on line 32.
Open

      .includes(:user, subject: [:story])
Severity: Minor
Found in app/models/activity.rb by rubocop

Align .since with where("subject_type in ('Project', 'Story')") on line 28.
Open

      .since(since).to_a
Severity: Minor
Found in app/models/activity.rb by rubocop

Shadowing outer local variable - activities.
Open

        activities.group_by(&:project_id).map do |project_id, activities|
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop looks for use of the same name as outer local variables for block arguments or block local variables. This is a mimic of the warning "shadowing outer local variable - foo" from ruby -cw.

Example:

# bad

def some_method
  foo = 1

  2.times do |foo| # shadowing outer `foo`
    do_something(foo)
  end
end

Example:

# good

def some_method
  foo = 1

  2.times do |bar|
    do_something(bar)
  end
end

Align .since with where("subject_type in ('Note', 'Task')") on line 32.
Open

      .since(since).to_a
Severity: Minor
Found in app/models/activity.rb by rubocop

Shadowing outer local variable - activities.
Open

            end.map do |subject_type, activities|
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop looks for use of the same name as outer local variables for block arguments or block local variables. This is a mimic of the warning "shadowing outer local variable - foo" from ruby -cw.

Example:

# bad

def some_method
  foo = 1

  2.times do |foo| # shadowing outer `foo`
    do_something(foo)
  end
end

Example:

# good

def some_method
  foo = 1

  2.times do |bar|
    do_something(bar)
  end
end

Avoid multi-line chains of blocks.
Open

    end.map do |date, activities|
Severity: Minor
Found in app/models/activity.rb by rubocop

This cop checks for chaining of a block after another block that spans multiple lines.

Example:

Thread.list.find_all do |t|
  t.alive?
end.map do |t|
  t.object_id
end

There are no issues that match your filters.

Category
Status