Codeminer42/cm42-central

View on GitHub
app/models/project.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class has too many lines. [121/110]
Open

class Project < ApplicationRecord
  attr_writer :suppress_notifications

  POINT_SCALES = {
    'fibonacci' => [1, 2, 3, 5, 8].freeze,
Severity: Minor
Found in app/models/project.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Complex method Project::has_many#from_csv (92.1)
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Assignment Branch Condition size for from_csv is too high. [56.86/25]
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [39/25]
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method from_csv has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for from_csv is too high. [12/6]
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for from_csv is too high. [12/8]
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method from_csv has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def from_csv(csv_string)
      # Eager load this so that we don't have to make multiple db calls when
      # searching for users by full name from the CSV.
      users = proxy_association.owner.users

Severity: Minor
Found in app/models/project.rb - About 1 hr to fix

    Prefer annotated tokens (like %<foo>s</foo>) over template tokens (like %{foo}).
    Open

                                           message: '%{value} is not a valid estimation scheme' }
    Severity: Minor
    Found in app/models/project.rb by rubocop

    Use a consistent style for named format string tokens.

    Example:

    EnforcedStyle: annotated
    
    # bad
    
    format('%{greeting}', greeting: 'Hello')
    format('%s', 'Hello')
    
    # good
    
    format('%<greeting>s', greeting: 'Hello')</greeting>

    Example:

    EnforcedStyle: template
    
    # bad
    
    format('%<greeting>s', greeting: 'Hello')
    format('%s', 'Hello')
    
    # good
    
    format('%{greeting}', greeting: 'Hello')</greeting>

    Avoid the use of double negation (!!).
    Open

        !!archived_at
    Severity: Minor
    Found in app/models/project.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Line is too long. [111/100]
    Open

            story.project.suppress_notifications = true # otherwise the import will generate massive notifications!
    Severity: Minor
    Found in app/models/project.rb by rubocop

    There are no issues that match your filters.

    Category
    Status