Sign upLogin

Codeminer42/cm42-central

View on GitHub
Star
app/services/remove_stories_from_user_service.rb

Summary

Maintainability
A
25 mins
Test Coverage

Complex method RemoveStoriesFromUserService#call (33.6)
Open

  def call
    project.stories
           .where(requested_by_id: user.id)
           .or(project.stories.where(owned_by_id: user.id))
           .where.not(state: "accepted").each do |story|
Severity: Minor
Found in app/services/remove_stories_from_user_service.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def call
    project.stories
           .where(requested_by_id: user.id)
           .or(project.stories.where(owned_by_id: user.id))
           .where.not(state: "accepted").each do |story|
Severity: Minor
Found in app/services/remove_stories_from_user_service.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is too long. [105/100]
Open

      requested_by_attrs = user.requested?(story) ? { requested_by_id: nil, requested_by_name: nil } : {}
Severity: Minor
Found in app/services/remove_stories_from_user_service.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

           .where.not(state: "accepted").each do |story|
Severity: Minor
Found in app/services/remove_stories_from_user_service.rb by rubocop

There are no issues that match your filters.

Category
Status