Sign upLogin

CommunityGrows/communitygrows

View on GitHub
Star

Showing 187 of 187 total issues

end at 7, 3 is not aligned with def at 4, 1.
Open

      end
Severity: Minor
Found in app/models/category.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Don't use IDs in selectors.
Open

#navbar.navbar-collapse {
Severity: Minor
Found in app/assets/stylesheets/base.css by csslint

Don't use IDs in selectors.
Open

#announcements {
Severity: Minor
Found in app/assets/stylesheets/base.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

#calendar_html {
Severity: Minor
Found in app/assets/stylesheets/base.css by csslint

end at 37, 8 is not aligned with order.each_with_index do |id, i| at 35, 2.
Open

        end
Severity: Minor
Found in app/models/category.rb by rubocop

This cop checks whether the end keywords are aligned properly for do end blocks.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

start_of_block : the end shall be aligned with the start of the line where the do appeared.

start_of_line : the end shall be aligned with the start of the line where the expression started.

either (which is the default) : the end is allowed to be in either location. The autofixer will default to start_of_line.

Example: EnforcedStyleAlignWith: either (default)

# bad

foo.bar
   .each do
     baz
       end

# good

variable = lambda do |i|
  i
end

Example: EnforcedStyleAlignWith: startofblock

# bad

foo.bar
   .each do
     baz
       end

# good

foo.bar
  .each do
     baz
   end

Example: EnforcedStyleAlignWith: startofline

# bad

foo.bar
   .each do
     baz
       end

# good

foo.bar
  .each do
     baz
end

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

        rescue Exception => e
            flash[:notice] = flash[:notice].to_a.concat @user.errors.full_messages
            redirect_to new_user_path
Severity: Minor
Found in app/controllers/admin_controller.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Useless assignment to variable - e.
Open

        rescue Exception => e
Severity: Minor
Found in app/controllers/admin_controller.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end
Severity
Category
Status
Source
Language