Sign upLogin

ComplianceAsCode/content

View on GitHub
Star
build-scripts/collect_remediations.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function process_remediation has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def process_remediation(
Severity: Major
Found in build-scripts/collect_remediations.py - About 50 mins to fix

    Function collect_remediations has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def collect_remediations(
    Severity: Major
    Found in build-scripts/collect_remediations.py - About 50 mins to fix

      Function find_remediation has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def find_remediation(
      Severity: Minor
      Found in build-scripts/collect_remediations.py - About 35 mins to fix

        Merge this if statement with the enclosing one.
        Open

                if os.path.isdir(language_fixes_from_templates_dir):
        Severity: Major
        Found in build-scripts/collect_remediations.py by sonar-python

        Merging collapsible if statements increases the code's readability.

        Noncompliant Code Example

        if condition1:
    if condition2:
        # ...

        Compliant Solution

        if condition1 and condition2:
    # ...

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try:
            process_remediation(
                rule, fix_path, lang, output_dirs, expected_file_name, env_yaml, cpe_platforms)
        except Exception as exc:
            msg = (
        Severity: Major
        Found in build-scripts/collect_remediations.py and 1 other location - About 1 hr to fix
        ssg/build_yaml.py on lines 1133..1141

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status