Sign upLogin

ComplianceAsCode/content

View on GitHub
Star
utils/ansible_shell_diff.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_shell_tasks has a Cognitive Complexity of 18 (exceeds 7 allowed). Consider refactoring.
Open

def get_shell_tasks(tasks):
    """
    Find all shell/command module tasks.
    Module can be as FQCN or just short name.
    Both forms, free form and 'cmd:' parameter, are supported.
Severity: Minor
Found in utils/ansible_shell_diff.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
Open

def get_shell_tasks(tasks):
Severity: Critical
Found in utils/ansible_shell_diff.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

There are no issues that match your filters.

Category
Status