Sign upLogin

ConnectCorp/nexmo-client

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Nexmo\Service\Number;

use Nexmo\Entity\MatchingStrategy;
Severity: Major
Found in src/Service/Number/Buy.php and 1 other location - About 5 hrs to fix
src/Service/Number/Cancel.php on lines 1..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Nexmo\Service\Number;

use Nexmo\Entity\MatchingStrategy;
Severity: Major
Found in src/Service/Number/Cancel.php and 1 other location - About 5 hrs to fix
src/Service/Number/Buy.php on lines 1..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function validateResponse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function validateResponse(array $json)
    {
        if (!isset($json['count'])) {
            throw new Exception('count property expected');
        }
Severity: Minor
Found in src/Service/Account/Numbers.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method invoke has 13 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $from = null,
        $to = null,
        $type = 'text',
        $text = '',
        $statusReportReq = null,
Severity: Major
Found in src/Service/Message.php - About 1 hr to fix

    Function validateResponse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function validateResponse(array $json)
    {
        if (!isset($json['country'])) {
            throw new Exception('country property expected');
        }
    Severity: Minor
    Found in src/Service/Account/Pricing/Country.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method invoke has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function invoke(
        $from = null,
        $to = null,
        $type = 'text',
        $text = '',
    Severity: Minor
    Found in src/Service/Message.php - About 1 hr to fix

      Function validateResponse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function validateResponse(array $json)
    {
        if (!isset($json['message-count'])) {
            throw new NexmoException('message-count property expected');
        }
      Severity: Minor
      Found in src/Service/MarketingMessage.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateResponse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function validateResponse(array $json)
    {
        if (!isset($json['message-count'])) {
            throw new NexmoException('message-count property expected');
        }
      Severity: Minor
      Found in src/Service/Message.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function invoke($country = null, $index = 1, $size = 10, $pattern = null, $searchPattern = MatchingStrategy::STARTS_WITH, $features = 'SMS')
      Severity: Minor
      Found in src/Service/Number/Search.php - About 45 mins to fix

        Method search has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function search($country = null, $index = 1, $size = 10, $pattern = null, $searchPattern = MatchingStrategy::STARTS_WITH, $features = 'SMS')
        Severity: Minor
        Found in src/Service/Number.php - About 45 mins to fix

          Method invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function invoke($number = null, $brand = null, $senderId = null, $codeLength = null, $lg = null, $requireType = null)
          Severity: Minor
          Found in src/Service/Verify.php - About 45 mins to fix

            Function invoke has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function invoke(
        $from = null,
        $to = null,
        $type = 'text',
        $text = '',
            Severity: Minor
            Found in src/Service/Message.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language