Sign upLogin

ConsorciAOC-PRJ/decidim-module-trusted-ids

View on GitHub
Star

Showing 3 of 3 total issues

Method save_census_config! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

          def save_census_config!(organization)
            conf = Decidim::TrustedIds::OrganizationConfig.find_or_initialize_by(organization: organization)
            conf.handler = TrustedIds.census_authorization[:handler]
            return if conf.handler.blank?
Severity: Minor
Found in app/commands/concerns/decidim/trusted_ids/system/needs_census_config.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expires_at has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def expires_at
          return unless workflow_manifest

          expires_in = organization.trusted_ids_census_config&.expiration_days&.days&.to_i || workflow_manifest.expires_in
          return if expires_in.zero?
Severity: Minor
Found in app/models/concerns/decidim/trusted_ids/authorization_override.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method map_model has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

          def map_model(model)
            self.secondary_hosts = model.secondary_hosts.join("\n")
            self.omniauth_settings = (model.omniauth_settings || {}).transform_values do |v|
              Decidim::OmniauthProvider.value_defined?(v) ? Decidim::AttributeEncryptor.decrypt(v) : v
            end
Severity: Minor
Found in app/forms/concerns/decidim/trusted_ids/system/organization_form_override.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language