Sign upLogin

Cooomma/ksm-golang

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func AESECBEncrypt(key, plainText []byte) ([]byte, error) {
    logger.Println("AES-ECB Encrpypt: PlainText Length:", len(plainText))
    if len(plainText)%aes.BlockSize != 0 {
        return nil, fmt.Errorf("need a multiple of the blocksize")
    }
Severity: Major
Found in cryptos/aes.go and 1 other location - About 2 hrs to fix
cryptos/aes.go on lines 83..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 203.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func AESECBDecrypt(key, cipherText []byte) ([]byte, error) {
    logger.Println("AES-ECB: cipherText Length:", len(cipherText))
    if len(cipherText)%aes.BlockSize != 0 {
        return nil, fmt.Errorf("input not full blocks")
    }
Severity: Major
Found in cryptos/aes.go and 1 other location - About 2 hrs to fix
cryptos/aes.go on lines 62..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 203.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function main has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    // Setting Echo
    e := echo.New()

    e.Use(middleware.Logger())
Severity: Minor
Found in api/api.go - About 1 hr to fix

    Function parseTLLVs has 72 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func parseTLLVs(spcPayload []byte) map[uint64]TLLVBlock {
    var m map[uint64]TLLVBlock
    m = make(map[uint64]TLLVBlock)

    for currentOffset := 0; currentOffset < len(spcPayload); {
    Severity: Minor
    Found in ksm/ksm.go - About 1 hr to fix

      Method Ksm.GenCKC has 70 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (k *Ksm) GenCKC(playback []byte) ([]byte, error) {
    spcv1, err := ParseSPCV1(playback, k.Pub, k.Pri)
    if err != nil {
        return nil, err
    }
      Severity: Minor
      Found in ksm/ksm.go - About 1 hr to fix

        Method Ksm.GenCKC has 13 return statements (exceeds 4 allowed).
        Open

        func (k *Ksm) GenCKC(playback []byte) ([]byte, error) {
    spcv1, err := ParseSPCV1(playback, k.Pub, k.Pri)
    if err != nil {
        return nil, err
    }
        Severity: Major
        Found in ksm/ksm.go - About 1 hr to fix

          Function main has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
          Open

          func main() {
    // Setting Echo
    e := echo.New()

    e.Use(middleware.Logger())
          Severity: Minor
          Found in api/api.go - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method DFunction.Compute has 5 return statements (exceeds 4 allowed).
          Open

          func (d DFunction) Compute(R2 []byte, ask []byte) ([]byte, error) {

    if hex.EncodeToString(ask) == APPLE_TESTING_ASk {
        return hex.DecodeString(APPLE_TESTING_ASk)
    }
          Severity: Major
          Found in ksm/d_function.go - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language