Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
app/controllers/concerns/course/lesson_plan/strategies/stragglers_personalization_strategy.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method cannot_shift_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

  def cannot_shift_item(course_user, item, submitted_items, reference_point, items_to_shift)
Severity: Minor
Found in app/controllers/concerns/course/lesson_plan/strategies/stragglers_personalization_strategy.rb - About 35 mins to fix

Method shift_end_at has 5 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

  def shift_end_at(personal_time, reference_time, personal_point, reference_point, learning_rate_ema)
Severity: Minor
Found in app/controllers/concerns/course/lesson_plan/strategies/stragglers_personalization_strategy.rb - About 35 mins to fix

Method update_points has 5 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

  def update_points(course_user, item, submitted_items, reference_point, personal_point)
Severity: Minor
Found in app/controllers/concerns/course/lesson_plan/strategies/stragglers_personalization_strategy.rb - About 35 mins to fix

Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Wontfix

  def execute(course_user, precomputed_data, items_to_shift = nil) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
    return if precomputed_data[:learning_rate_ema].nil?

    @course_tz = course_user.course.time_zone
    reference_point = personal_point = precomputed_data[:items].first.reference_time_for(course_user).end_at
Severity: Minor
Found in app/controllers/concerns/course/lesson_plan/strategies/stragglers_personalization_strategy.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status