Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
app/controllers/course/learning_map_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class LearningMapController has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class Course::LearningMapController < Course::ComponentController
  NODE_ID_DELIMITER = '-'
  NEGATIVE_INF = -1_000_000_000

  before_action :authorize_learning_map
Severity: Minor
Found in app/controllers/course/learning_map_controller.rb - About 2 hrs to fix

Method generate_nodes_from_conditionals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def generate_nodes_from_conditionals(all_node_relations) # rubocop:disable Metrics/AbcSize
    node_ids_to_children = all_node_relations[:node_ids_to_children]
    node_ids_to_parents = all_node_relations[:node_ids_to_parents]
    node_ids_to_unlock_level = all_node_relations[:node_ids_to_unlock_level]
    students = current_course.course_users.students
Severity: Minor
Found in app/controllers/course/learning_map_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status