Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
app/models/concerns/course/assessment/submission/notification_concern.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method send_submit_notification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def send_submit_notification
    return unless workflow_state_before_last_save == 'attempting'
    # When a course staff submits/force submits a submission on behalf of the student,
    # the updater of the submission is set as the course staff, which is different from the creator (the student).
    # Even though a submission is force created by a course staff, the creator is still set
Severity: Minor
Found in app/models/concerns/course/assessment/submission/notification_concern.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status