Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
app/models/concerns/course/assessment/submission/todo_concern.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method update_todo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def update_todo
    return unless todo

    if attempting?
      todo.update_attribute(:workflow_state, 'in_progress') unless todo.in_progress?
Severity: Minor
Found in app/models/concerns/course/assessment/submission/todo_concern.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restart_todo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def restart_todo
    return if assessment.destroying? || todo.nil?

    todo.update_attribute(:workflow_state, 'not_started') unless todo.not_started?
  rescue ActiveRecord::ActiveRecordError => e
Severity: Minor
Found in app/models/concerns/course/assessment/submission/todo_concern.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status