Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
client/app/bundles/course/discussion/topics/store.ts

Summary

Maintainability
D
1 day
Test Coverage

Function reducer has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

const reducer = produce((draft: CommentState, action: CommentActionType) => {
  switch (action.type) {
    case SAVE_COMMENT_TAB: {
      draft.permissions = { ...action.permissions };
      draft.settings = { ...action.settings };
Severity: Minor
Found in client/app/bundles/course/discussion/topics/store.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function reducer has 152 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reducer = produce((draft: CommentState, action: CommentActionType) => {
  switch (action.type) {
    case SAVE_COMMENT_TAB: {
      draft.permissions = { ...action.permissions };
      draft.settings = { ...action.settings };
Severity: Major
Found in client/app/bundles/course/discussion/topics/store.ts - About 6 hrs to fix

Avoid deeply nested control flow statements.
Open

          if (
            draft.pageState.tabValue === CommentTabTypes.MY_STUDENTS_PENDING ||
            draft.pageState.tabValue === CommentTabTypes.MY_STUDENTS
          ) {
            draft.tabs.myStudentUnreadCount! += 1;
Severity: Major
Found in client/app/bundles/course/discussion/topics/store.ts - About 45 mins to fix

There are no issues that match your filters.

Category
Status