Sign upLogin

Covivo/mobicoop

View on GitHub
Star
api/src/DataFixtures/BasicFixtures.php

Summary

Maintainability
A
3 hrs
Test Coverage

Avoid deeply nested control flow statements.
Open

                            if (!$ad->isOneWay()) {
                                $returnProposal = $this->proposalManager->prepareProposal($this->proposalManager->get($outwardProposal->getProposalLinked()->getId()));
                                $this->matchingRepository->linkRelatedMatchings($outwardProposal->getId());
                            }
Severity: Major
Found in api/src/DataFixtures/BasicFixtures.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if (Ad::ROLE_DRIVER_OR_PASSENGER == $ad->getRole()) {
                                // linking for the outward
                                $this->matchingRepository->linkOppositeMatchings($outwardProposal->getId());
                                if (!$ad->isOneWay()) {
                                    // linking for the return
    Severity: Major
    Found in api/src/DataFixtures/BasicFixtures.php - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function __construct(
        BasicFixturesManager $fixturesManager,
        ProposalManager $proposalManager,
        MatchingRepository $matchingRepository,
        TerritoryManager $territoryManager,
      Severity: Major
      Found in api/src/DataFixtures/BasicFixtures.php and 1 other location - About 2 hrs to fix
      api/src/Journey/Service/JourneyManager.php on lines 55..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status