Sign upLogin

Covivo/mobicoop

View on GitHub
Star
api/src/DataProvider/Entity/MangoPayProvider.php

Summary

Maintainability
D
2 days
Test Coverage

MangoPayProvider has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class MangoPayProvider implements PaymentProviderInterface
{
    public const SERVER_URL_SANDBOX = 'https://api.sandbox.mangopay.com/';
    public const SERVER_URL = 'https://api.mangopay.com/';
    public const LANDING_AFTER_PAYMENT = 'paiements/paye';
Severity: Minor
Found in api/src/DataProvider/Entity/MangoPayProvider.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                switch ($data['RefusedReasonType']) {
                case self::OUT_OF_DATE:
                    $validationDocument->setStatus(ValidationDocument::OUT_OF_DATE);

                    break;
    Severity: Major
    Found in api/src/DataProvider/Entity/MangoPayProvider.php and 1 other location - About 6 hrs to fix
    api/src/Payment/Service/PaymentManager.php on lines 1220..1270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 208.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function triggerPayout(string $authorIdentifier, Wallet $wallet, BankAccount $bankAccount, float $amount, string $reference = ''): ?string
    {
        $body = [
            'AuthorId' => $authorIdentifier,
            'DebitedFunds' => [
    Severity: Major
    Found in api/src/DataProvider/Entity/MangoPayProvider.php and 1 other location - About 5 hrs to fix
    api/src/DataProvider/Entity/MangoPayProvider.php on lines 664..693

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 193.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function transferWalletToWallet(string $debtorIdentifier, Wallet $walletFrom, Wallet $walletTo, float $amount, string $tag = ''): ?string
    {
        $body = [
            'AuthorId' => $debtorIdentifier,
            'DebitedFunds' => [
    Severity: Major
    Found in api/src/DataProvider/Entity/MangoPayProvider.php and 1 other location - About 5 hrs to fix
    api/src/DataProvider/Entity/MangoPayProvider.php on lines 698..727

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 193.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status