Sign upLogin

Covivo/mobicoop

View on GitHub
Star
api/src/Payment/Entity/CarpoolItem.php

Summary

Maintainability
C
1 day
Test Coverage

CarpoolItem has 60 functions (exceeds 20 allowed). Consider refactoring.
Open

class CarpoolItem
{
    public const STATUS_INITIALIZED = 0;               // carpool supposed to be done
    public const STATUS_REALIZED = 1;                  // carpool confirmed
    public const STATUS_NOT_REALIZED = 2;              // carpool invalidated (no carpool for this day)
Severity: Major
Found in api/src/Payment/Entity/CarpoolItem.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                !is_null($this->getAsk())
            && !is_null($this->getAsk()->getMatching())
            && !is_null($this->getAsk()->getMatching()->getProposalOffer())
            && !is_null($this->getAsk()->getMatching()->getProposalOffer()->getUser())
            && $user->getId() === $this->getAsk()->getMatching()->getProposalOffer()->getUser()->getId()
    Severity: Major
    Found in api/src/Payment/Entity/CarpoolItem.php and 1 other location - About 1 hr to fix
    api/src/Incentive/Entity/LongDistanceSubscription.php on lines 900..904

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status