Sign upLogin

Covivo/mobicoop

View on GitHub
Star
client/src/MobicoopBundle/Api/Service/Deserializer.php

Summary

Maintainability
D
3 days
Test Coverage

Deserializer has 74 functions (exceeds 20 allowed). Consider refactoring.
Open

class Deserializer
{
    public const DATETIME_FORMAT = \DateTime::ISO8601;
    public const SETTER_PREFIX = 'set';
Severity: Major
Found in client/src/MobicoopBundle/Api/Service/Deserializer.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializeMessage(array $data): ?Message
    {
        $message = new Message();
        $message = $this->autoSet($message, $data);
        if (isset($data['@id'])) {
    Severity: Major
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 4 hrs to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 511..531

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 178.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializeProposal(array $data): ?Proposal
    {
        $proposal = new Proposal();
        $proposal = $this->autoSet($proposal, $data);
        if (isset($data['@id'])) {
    Severity: Major
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 4 hrs to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 945..965

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 178.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializeArticle(array $data): ?Article
    {
        $article = new Article();
        $article = $this->autoSet($article, $data);
        if (isset($data['@id'])) {
    Severity: Major
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 1 hr to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 907..921

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializeSection(array $data): ?Section
    {
        $section = new Section();
        $section = $this->autoSet($section, $data);
        if (isset($data['@id'])) {
    Severity: Major
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 1 hr to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 891..905

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializeCsMessage(array $data): ?CsMessage
    {
        $csMessage = new CsMessage();
        if (isset($data['from'])) {
            $csMessage->setFrom($this->deserializeCsUser($data['from']));
    Severity: Minor
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 45 mins to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 1084..1095

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function deserializePaymentItem(array $data): ?PaymentItem
    {
        $paymentItem = new PaymentItem();
        if (isset($data['origin'])) {
            $paymentItem->setOrigin($this->deserializeAddress($data['origin']));
    Severity: Minor
    Found in client/src/MobicoopBundle/Api/Service/Deserializer.php and 1 other location - About 45 mins to fix
    client/src/MobicoopBundle/Api/Service/Deserializer.php on lines 1256..1267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status