Covivo/mobicoop

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            } else {
                if (1 == $waypoint['candidate'] && (int) $waypoint['position'] > $steps['carpooler']) {
                    $steps['carpooler'] = (int) $waypoint['position'];
                } elseif (2 == $waypoint['candidate'] && (int) $waypoint['position'] > $steps['requester']) {
                    $steps['requester'] = (int) $waypoint['position'];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static function isCarpoolProofDataComplete(CarpoolProof $carpoolProof): bool
    {
        return
            !is_null($carpoolProof->getPickUpDriverAddress())
            && !is_null($carpoolProof->getPickUpDriverDate())

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private function randomPassword()
    {
        $alphabet = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890';
        $pass = []; // remember to declare $pass as an array
        $alphaLength = strlen($alphabet) - 1; // put the length -1 in cache

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getTueTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                        if (                                    // 1.2.2. First journey validation after published deadline
                            $this->isDateAfterPublishedDeadline($this->_today)
                        ) {
                            $this->_version = self::EEC_VERSION_IMPROVED;
                        }

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getMonTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                        if (                                    // 1.2.1. Ld first journey realised before the published deadline
                            $this->isDateBeforePublishedDeadline($this->_currentCommitmentJourney->getInitialProposal()->getCriteria()->getFromDate())
                        ) {
                            $this->_version = self::EEC_VERSION_STANDARD;
                        }

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getThuTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                        if (                                    // 1.2.1. Ld first journey realised after the published deadline
                            $this->isDateAfterPublishedDeadline($this->_currentCommitmentJourney->getInitialProposal()->getCriteria()->getFromDate())
                        ) {
                            $this->_version = self::EEC_VERSION_IMPROVED;
                        }

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getFriTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                        if ('' !== $tab[$i]) {
                            $massPerson->{$setter}($tab[$i]);
                        }

Avoid deeply nested control flow statements.

Open

                            if (Ad::ROLE_DRIVER_OR_PASSENGER == $ad->getRole()) {
                                // linking for the outward
                                $this->matchingRepository->linkOppositeMatchings($outwardProposal->getId());
                                if (!$ad->isOneWay()) {
                                    // linking for the return

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getSatTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                        if (method_exists($personalAddress, $setter)) {
                            $personalAddress->{$setter}(strtoupper($tab[$i]));
                        }

Avoid deeply nested control flow statements.

Open

                        if (method_exists($workAddress, $setter)) {
                            $workAddress->{$setter}(strtoupper($tab[$i]));
                        }

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getSunTime())) {
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                            if (!$ad->isOneWay()) {
                                $returnProposal = $this->proposalManager->prepareProposal($this->proposalManager->get($outwardProposal->getProposalLinked()->getId()));
                                $this->matchingRepository->linkRelatedMatchings($outwardProposal->getId());
                            }

Avoid deeply nested control flow statements.

Open

                        if (                                    // 1.2.1. First journey validation before published deadline
                            $this->isDateAfterPublishedDeadline($this->_today)
                        ) {
                            $this->_version = self::EEC_VERSION_STANDARD;
                        }

Avoid deeply nested control flow statements.

Open

                                    if (is_null($ask->getCriteria()->getWedTime())) {
                                        break;
                                    }

Similar blocks of code found in 14 locations. Consider refactoring.

Open

                        if (isset($matching['request']->getFilters()['pickup']['sunMinPickupTime'], $matching['request']->getFilters()['pickup']['sunMaxPickupTime'])) {
                            $item->setSunCheck(true);
                            $item->setSunTime($proposal->getCriteria()->getSunTime());
                            $item->setTime($proposal->getCriteria()->getSunTime());
                            $item->setSunMarginDuration($proposal->getCriteria()->getSunMarginDuration());

• Read up
  Read up