Sign upLogin

CrossKnowledge/SubConverterBundle

View on GitHub
Star

Showing 10 of 10 total issues

Function export has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function export($bom = false)
    {
        $templateDir = __DIR__ .'/../Resources/ttaf1_templates/';

        // Use template file
Severity: Minor
Found in Providers/Ttaf1Subtitles.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method export has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function export($bom = false)
    {
        $templateDir = __DIR__ .'/../Resources/ttaf1_templates/';

        // Use template file
Severity: Major
Found in Providers/Ttaf1Subtitles.php - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function export($bom = false)
    {
        $webvtt = "WEBVTT\n\n";

        $i = 1;
    Severity: Major
    Found in Providers/WebVttSubtitles.php and 1 other location - About 3 hrs to fix
    Providers/SubRipSubtitles.php on lines 77..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 147.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function export($bom = false)
    {
        $srt = '';

        $i = 1;
    Severity: Major
    Found in Providers/SubRipSubtitles.php and 1 other location - About 3 hrs to fix
    Providers/WebVttSubtitles.php on lines 76..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 147.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method import has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid TTAF1 file: ".basename($filename));
        }
    Severity: Major
    Found in Providers/Ttaf1Subtitles.php - About 2 hrs to fix

      Function import has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid TTAF1 file: ".basename($filename));
        }
      Severity: Minor
      Found in Providers/Ttaf1Subtitles.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid text file: ".basename($filename));
        }
      Severity: Minor
      Found in Providers/TxtSubtitles.php - About 1 hr to fix

        Method import has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid WebVTT file: ".basename($filename));
        }
        Severity: Minor
        Found in Providers/WebVttSubtitles.php - About 1 hr to fix

          Method import has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid SubRip file: ".basename($filename));
        }
          Severity: Minor
          Found in Providers/SubRipSubtitles.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in Providers/SubtitlesFactory.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language