Sign upLogin

CrossKnowledge/SubConverterBundle

View on GitHub
Star

Showing 8 of 10 total issues

Function export has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function export($bom = false)
    {
        $templateDir = __DIR__ .'/../Resources/ttaf1_templates/';

        // Use template file
Severity: Minor
Found in Providers/Ttaf1Subtitles.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method export has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function export($bom = false)
    {
        $templateDir = __DIR__ .'/../Resources/ttaf1_templates/';

        // Use template file
Severity: Major
Found in Providers/Ttaf1Subtitles.php - About 3 hrs to fix

    Method import has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid TTAF1 file: ".basename($filename));
        }
    Severity: Major
    Found in Providers/Ttaf1Subtitles.php - About 2 hrs to fix

      Function import has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid TTAF1 file: ".basename($filename));
        }
      Severity: Minor
      Found in Providers/Ttaf1Subtitles.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid text file: ".basename($filename));
        }
      Severity: Minor
      Found in Providers/TxtSubtitles.php - About 1 hr to fix

        Method import has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid WebVTT file: ".basename($filename));
        }
        Severity: Minor
        Found in Providers/WebVttSubtitles.php - About 1 hr to fix

          Method import has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function import($filename)
    {
        if (!$this->checkFormat($filename)) {
            throw new \Exception("Invalid SubRip file: ".basename($filename));
        }
          Severity: Minor
          Found in Providers/SubRipSubtitles.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in Providers/SubtitlesFactory.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language