Sign upLogin

CuyZ/NotiZ

View on GitHub
Star

Showing 89 of 122 total issues

The class PropertyFactory has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class PropertyFactory implements SingletonInterface
{
    const SIGNAL_PROPERTY_BUILD_DEFINITION = 'propertyBuildDefinition';

    const SIGNAL_PROPERTY_FILLING = 'propertyFilling';
Severity: Minor
Found in Classes/Core/Property/Factory/PropertyFactory.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The class NotificationTcaService has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
Open

abstract class NotificationTcaService implements SingletonInterface
{
    /**
     * @var EventFactory
     */
Severity: Minor
Found in Classes/Core/Notification/Service/NotificationTcaService.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The class LocalConfigurationService has a coupling between objects value of 27. Consider to reduce the number of dependencies under 13.
Open

class LocalConfigurationService implements SingletonInterface, TableConfigurationPostProcessingHookInterface
{
    use SelfInstantiateTrait;

    /**
Severity: Minor
Found in Classes/Service/Extension/LocalConfigurationService.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The class NotificationDispatcher has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
Open

class NotificationDispatcher implements SingletonInterface
{
    /**
     * @var Definition
     */
Severity: Minor
Found in Classes/Core/Notification/NotificationDispatcher.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EventDefinition $eventDefinition,
        EventFactory $eventFactory,
        NotificationDispatcher $notificationDispatcher,
        Dispatcher $signalDispatcher,
        ExtensionConfigurationService $extensionConfigurationService
Severity: Minor
Found in Classes/Core/Event/Runner/EventRunner.php - About 35 mins to fix

    Method compile has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function compile($argumentsName, $closureName, &$initializationPhpCode, ViewHelperNode $node, TemplateCompiler $compiler)
    Severity: Minor
    Found in Classes/ViewHelpers/Slot/RenderViewHelper.php - About 35 mins to fix

      Function fillPropertyDefinition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fillPropertyDefinition(PropertyDefinition $definition)
    {
        if (version_compare(VersionNumberUtility::getCurrentTypo3Version(), '9.0.0', '<')) {
            $this->fillPropertyDefinitionLegacy($definition);
            return;
      Severity: Minor
      Found in Classes/Core/Property/Service/TagsPropertyService.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '172', column '24').
      Open

                      : (new \ReflectionClass($definition->getEventClassName()))->getDefaultProperties()[$name];
      Severity: Minor
      Found in Classes/Core/Property/Service/TagsPropertyService.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method createQuery has a boolean flag argument $withDisabled, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function createQuery(bool $withDisabled = false): QueryInterface
      Severity: Minor
      Found in Classes/Domain/Repository/EntityNotificationRepository.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getQueryForEvent has a boolean flag argument $withDisabled, which is a certain sign of a Single Responsibility Principle violation.
      Open

          protected function getQueryForEvent(EventDefinition $eventDefinition, bool $withDisabled = false): QueryInterface
      Severity: Minor
      Found in Classes/Domain/Repository/EntityNotificationRepository.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '172', column '24').
      Open

                      : (new \ReflectionClass($definition->getEventClassName()))->getDefaultProperties()[$name];
      Severity: Minor
      Found in Classes/Core/Property/Service/TagsPropertyService.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function dataPreProcessor(DataPreProcessor $processor)
    {
        $data = $processor->getData();

        // View object must always be set.
      Severity: Minor
      Found in Classes/Domain/Notification/Email/Application/EntityEmail/Settings/EntityEmailSettings.php and 1 other location - About 30 mins to fix
      Classes/Domain/Notification/Slack/Application/EntitySlack/Settings/EntitySlackSettings.php on lines 81..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      The method createQuery has a boolean flag argument $withDisabled, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function createQuery(bool $withDisabled = false): QueryInterface
      Severity: Minor
      Found in Classes/Domain/Repository/EntityNotificationRepository.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function dataPreProcessor(DataPreProcessor $processor)
    {
        $data = $processor->getData();

        // Bots object must always be set.
      Severity: Minor
      Found in Classes/Domain/Notification/Slack/Application/EntitySlack/Settings/EntitySlackSettings.php and 1 other location - About 30 mins to fix
      Classes/Domain/Notification/Email/Application/EntityEmail/Settings/EntityEmailSettings.php on lines 72..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      The method getQueryForEvent has a boolean flag argument $withDisabled, which is a certain sign of a Single Responsibility Principle violation.
      Open

          protected function getQueryForEvent(EventDefinition $eventDefinition, bool $withDisabled = false): QueryInterface
      Severity: Minor
      Found in Classes/Domain/Repository/EntityNotificationRepository.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Function doList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function doList(array &$parameters)
    {
        foreach ($this->formPersistenceManager->listForms() as $form) {
            $persistenceIdentifier = $form['persistenceIdentifier'];
            $formDefinition = $this->formPersistenceManager->load($persistenceIdentifier);
      Severity: Minor
      Found in Classes/Domain/Event/Form/Service/ListFormNotifications.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fillPropertyDefinitionLegacy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function fillPropertyDefinitionLegacy(PropertyDefinition $definition)
    {
        $identifier = $this->getPropertyTagIdentifier($definition);

        /** @var ClassReflection $eventReflection */
      Severity: Minor
      Found in Classes/Core/Property/Service/TagsPropertyService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fetchSettingsClassName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function fetchSettingsClassName(array $data): array
    {
        $notificationClassName = $data['className'] ?? null;

        if (class_exists($notificationClassName)
      Severity: Minor
      Found in Classes/Core/Definition/Tree/Notification/NotificationDefinition.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getSlotValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getSlotValue(array $arguments, RenderingContextInterface $renderingContext): string
    {
        self::$currentVariableContainer = $renderingContext->getViewHelperVariableContainer();

        $result = '';
      Severity: Minor
      Found in Classes/ViewHelpers/Slot/RenderViewHelper.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mapRecipients has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function mapRecipients(array $recipientsIdentifiers): array
    {
        $recipients = [];

        foreach ($this->eventRecipients as $recipient) {
      Severity: Minor
      Found in Classes/Domain/Notification/Email/Application/EntityEmail/Service/EntityEmailAddressMapper.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language