Sign upLogin

CyberDeck/devise-fido-u2f

View on GitHub
Star

Showing 118 of 118 total issues

Extra blank line detected.
Open


require 'bundler/gem_tasks'
Severity: Minor
Found in Rakefile by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency capybara should appear before thin.
Open

  s.add_development_dependency "capybara"
Severity: Minor
Found in devise_fido_usf.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Line is too long. [133/80]
Open

  s.description = "Enables a Rails Devise app to authenticate users with a second factor, e.g. a FIDO U2F compatible hardware token."
Severity: Minor
Found in devise_fido_usf.gemspec by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    "changelog_uri" => "https://github.com/cyberdeck/devise-fido-u2f/blob/master/CHANGELOG.md",
Severity: Minor
Found in devise_fido_usf.gemspec by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [117/80]
Open

        migration_template "migration.rb", "db/migrate/create_#{table_name}.rb", migration_version: migration_version
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Line is too long. [116/80]
Open

    validates :user, :name, :key_handle, :public_key, :certificate, :counter, :last_authenticated_at, presence: true
Severity: Minor
Found in app/models/fido_usf/fido_usf_device.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "bundler/setup"
Severity: Minor
Found in bin/test by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

1 trailing blank lines detected.
Open

Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Line is too long. [112/80]
Open

            content.gsub "devise/fido_usf_registrations/device", "#{plural_scope}/fido_usf_registrations/device"
Severity: Minor
Found in lib/generators/devise_fido_usf/views_generator.rb by rubocop

Missing top-level class documentation comment.
Open

    class ViewsGenerator < Rails::Generators::Base
Severity: Minor
Found in lib/generators/devise_fido_usf/views_generator.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        invoke("devise_fido_usf:migrate", ["FidoUsfDevices"])
Severity: Minor
Found in lib/generators/devise_fido_usf/install_generator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Avoid comma after the last item of a hash.
Open

    "bug_tracker_uri" => "https://github.com/cyberdeck/devise-fido-u2f/issues",
Severity: Minor
Found in devise_fido_usf.gemspec by rubocop

This cop checks for trailing comma in array and hash literals.

Example: EnforcedStyleForMultiline: consistent_comma

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: comma

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: no_comma (default)

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Line is too long. [94/80]
Open

      desc "Creates the migration for the table which stores all registered FIDO USF devices."
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Line is too long. [172/80]
Open

Devise.add_module :fido_usf_registerable, :model => 'devise_fido_usf/models/fido_usf_registerable', :controller => :fido_usf_registrations, :route => :fido_usf_registration
Severity: Minor
Found in lib/devise_fido_usf.rb by rubocop

Line is too long. [101/80]
Open

    if @resource.nil? || !Devise::TRUE_VALUES.include?(session[:"#{resource_name}_password_checked"])
Severity: Minor
Found in app/controllers/devise/fido_usf_authentications_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
Severity: Minor
Found in devise_fido_usf.gemspec by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [97/80]
Open

      desc "Creates a FIDO U2F initializer for devise and copy locale files to your application."
Severity: Minor
Found in lib/generators/devise_fido_usf/install_generator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        unless options[:orm]
Severity: Minor
Found in lib/generators/devise_fido_usf/install_generator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok
Severity
Category
Status
Source
Language