Sign upLogin

CyberDeck/devise-fido-u2f

View on GitHub
Star
lib/generators/devise_fido_usf/migrate_generator.rb

Summary

Maintainability
A
0 mins
Test Coverage

Line is too long. [117/80]
Open

        migration_template "migration.rb", "db/migrate/create_#{table_name}.rb", migration_version: migration_version
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Line is too long. [86/80]
Open

      argument :attributes, type: :array, default: [], banner: "field:type field:type"
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Line is too long. [94/80]
Open

      desc "Creates the migration for the table which stores all registered FIDO USF devices."
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      source_root File.expand_path("../../templates", __FILE__)
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        migration_template "migration.rb", "db/migrate/create_#{table_name}.rb", migration_version: migration_version
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

1 trailing blank lines detected.
Open

Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Missing top-level class documentation comment.
Open

    class MigrateGenerator < ActiveRecord::Generators::Base
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if rails5?
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if rails5?
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      argument :attributes, type: :array, default: [], banner: "field:type field:type"
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      desc "Creates the migration for the table which stores all registered FIDO USF devices."
Severity: Minor
Found in lib/generators/devise_fido_usf/migrate_generator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

There are no issues that match your filters.

Category
Status