Cysha/casino-holdem

View on GitHub
src/Game/Round.php

Summary

Maintainability
F
3 days
Test Coverage

File Round.php has 428 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Cysha\Casino\Holdem\Game;

use Cysha\Casino\Cards\Contracts\CardResults;
Severity: Minor
Found in src/Game/Round.php - About 6 hrs to fix

    Round has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Round
    {
        /**
         * @var Uuid
         */
    Severity: Minor
    Found in src/Game/Round.php - About 6 hrs to fix

      Method collectChipTotal has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function collectChipTotal(): ChipPotCollection
          {
              $allInActionsThisRound = $this->leftToAct()->filter(function (array $value) {
                  return $value['action'] === LeftToAct::ALLIN;
              });
      Severity: Major
      Found in src/Game/Round.php - About 2 hrs to fix

        Method distributeWinnings has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function distributeWinnings()
            {
                $this->chipPots()
                    ->reverse()
                    ->each(function (ChipPot $chipPot) {
        Severity: Minor
        Found in src/Game/Round.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                                  return true;
          Severity: Major
          Found in src/Game/Round.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $chipPot->total()->amount() !== 0;
            Severity: Major
            Found in src/Game/Round.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $this->chipPots();
              Severity: Major
              Found in src/Game/Round.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return false;
                Severity: Major
                Found in src/Game/Round.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function dealRiver()
                      {
                          if ($this->dealer()->communityCards()->count() !== 4) {
                              throw RoundException::riverHasBeenDealt();
                          }
                  Severity: Major
                  Found in src/Game/Round.php and 1 other location - About 3 hrs to fix
                  src/Game/Round.php on lines 523..541

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function dealTurn()
                      {
                          if ($this->dealer()->communityCards()->count() !== 3) {
                              throw RoundException::turnHasBeenDealt();
                          }
                  Severity: Major
                  Found in src/Game/Round.php and 1 other location - About 3 hrs to fix
                  src/Game/Round.php on lines 546..564

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function postBigBlind(PlayerContract $player)
                      {
                          // Take chips from player
                          $chips = $this->bigBlind();
                  
                  
                  Severity: Minor
                  Found in src/Game/Round.php and 1 other location - About 40 mins to fix
                  src/Game/Round.php on lines 316..325

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 94.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function postSmallBlind(PlayerContract $player)
                      {
                          // Take chips from player
                          $chips = $this->smallBlind();
                  
                  
                  Severity: Minor
                  Found in src/Game/Round.php and 1 other location - About 40 mins to fix
                  src/Game/Round.php on lines 330..339

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 94.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status