DAS27/php-project-lvl2

View on GitHub

Showing 22 of 22 total issues

Call to undeclared function \collect()
Open

    $keys2 = collect($data2)->keys()->all();
Severity: Critical
Found in src/astBuilder.php by phan

Reduce the number of returns of this function 5, down to the maximum allowed 3.
Open

    return array_map(function ($key) use ($data1, $data2) {
Severity: Major
Found in src/astBuilder.php by sonar-php

Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

Noncompliant Code Example

With the default threshold of 3:

function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}
Severity
Category
Status
Source
Language