src/parsers.php
Missing class import via use statement (line '16', column '23'). Open
Open
throw new \Exception("Unknown format: {$format}");
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\Symfony\Component\Yaml\Yaml' in method 'parse'. Open
Open
return Yaml::parse($data, Yaml::PARSE_OBJECT_FOR_MAP);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Define and throw a dedicated exception instead of using a generic one. Open
Open
throw new \Exception("Unknown format: {$format}");
- Read upRead up
- Exclude checks
If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.
Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.
Noncompliant Code Example
throw new Exception(); // Noncompliant
Compliant Solution
throw new InvalidArgumentException(); // or throw new UnexpectedValueException();
See
- MITRE, CWE-397 - Declaration of Throws for Generic Exception
- CERT, ERR07-J. - Do not throw RuntimeException, Exception, or Throwable
Reference to constant PARSE_OBJECT_FOR_MAP
from undeclared class \Symfony\Component\Yaml\Yaml
Open
Open
return Yaml::parse($data, Yaml::PARSE_OBJECT_FOR_MAP);
- Exclude checks
Call to method parse
from undeclared class \Symfony\Component\Yaml\Yaml
Open
Open
return Yaml::parse($data, Yaml::PARSE_OBJECT_FOR_MAP);
- Exclude checks