Sign upLogin

DDCreationStudios/votingApp

View on GitHub
Star

Showing 55 of 55 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    poll: PropTypes.shape({
      question: PropTypes.string,
      answers: PropTypes.arrayOf(
                PropTypes.shape({
  answer: PropTypes.string,
Severity: Major
Found in src/components/singlePollPage/SinglePoll.js and 1 other location - About 1 hr to fix
src/components/singlePollPage/NewAnswer.js on lines 83..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { polls, user, postPoll } = this.props;
    const pollComp = polls.map((poll, index) =>
      (<div key={shortid.generate()}>
        <div className="col s12 m6 card-panel hoverable teal">
Severity: Minor
Found in src/components/pollsPage/Polls.js - About 1 hr to fix

    Function Polls has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function Polls(state = [], action) {
  switch (action.type) {
    case FETCHED_POLLS:
      return action.polls;
    case ADD_POLL: {
    Severity: Minor
    Found in src/ducks/polls.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderComponent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const renderComponent = () => {
      if (user.loggedIn) {
        return (
          <div>
            <li>
    Severity: Minor
    Found in src/components/sidebar/Sidebar.js - About 1 hr to fix

      Function Signup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const Signup = (props) => {
  const passToProps = (e) => {
    if (e) e.preventDefault();
    props.login(true);
  };
      Severity: Minor
      Found in src/components/sidebar/Signup.js - About 1 hr to fix

        Function Login has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const Login = (props) => {
  const passToProps = (e) => {
    if (e) e.preventDefault();
    props.login({ name: 'daniel' });
  };
        Severity: Minor
        Found in src/components/sidebar/Login.js - About 1 hr to fix

          Function Users has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default function Users(state = {}, action) {
  switch (action.type) {
    case FETCH_USER:
      const temp = () => {
        if (action.users === undefined) {
          Severity: Minor
          Found in src/ducks/user.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          <NewAnswerCon
                poll={props.state.poll}
                addEditPoll={props.addEditPoll}
                polls={props.polls}
                url={props.url}
            Severity: Major
            Found in src/components/singlePollPage/SinglePoll.js and 1 other location - About 1 hr to fix
            src/components/singlePollPage/SinglePoll.js on lines 45..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            <Poll
                  poll={props.state.poll}
                  updateVotes={props.updateVotes}
                  url={props.url}
                  polls={props.polls}
            Severity: Major
            Found in src/components/singlePollPage/SinglePoll.js and 1 other location - About 1 hr to fix
            src/components/singlePollPage/SinglePoll.js on lines 68..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                addAnswer = () => {
        this.setState(oldState => ({
            answers: [...oldState.answers, { answer: '', votes: 1 }],
        }));
    };
            Severity: Minor
            Found in src/components/singlePollPage/NewAnswerCon.js and 1 other location - About 50 mins to fix
            src/components/pollsPage/NewPollCon.js on lines 54..58

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                componentWillReceiveProps(nextProps) {
        this.setState({
            question: '',
            answers: [{ answer: '', votes: 1 }, { answer: '', votes: 1 }]
        });
            Severity: Minor
            Found in src/components/pollsPage/NewPollCon.js and 1 other location - About 50 mins to fix
            src/components/pollsPage/NewPollCon.js on lines 27..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                reset() {
        this.setState({
            question: '',
            answers: [{ answer: '', votes: 1 }, { answer: '', votes: 1 }]
        });
            Severity: Minor
            Found in src/components/pollsPage/NewPollCon.js and 1 other location - About 50 mins to fix
            src/components/pollsPage/NewPollCon.js on lines 20..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                addAnswer = () => {
        this.setState(oldState => ({
            answers: [...oldState.answers, { answer: '', votes: 1 }],
        }));
    };
            Severity: Minor
            Found in src/components/pollsPage/NewPollCon.js and 1 other location - About 50 mins to fix
            src/components/singlePollPage/NewAnswerCon.js on lines 35..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                  return done(null, user);
            Severity: Major
            Found in src/serverSideES6/config/passport.js - About 30 mins to fix

              Function SinglePoll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              const SinglePoll = (props) => {
  const renderDeleteBtn = () => {
    if (props.user.loggedIn) {
      return (
        <Link
              Severity: Minor
              Found in src/components/singlePollPage/SinglePoll.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language