Sign upLogin

DEFRA/ivory-front-office

View on GitHub
Star

Showing 5 of 11 total issues

Function handleGet has 81 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  async handleGet (request, h, errors) {
    const { flow } = request.server.app
    const registration = await this.restoreRegistration(request)

    const owner = await Owner.get(request) || {}
Severity: Major
Found in server/modules/check-your-answers/check-your-answers.handlers.js - About 2 hrs to fix

    Function register has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        register: (server) => {
      server.ext('onPostAuth', async (request, h) => {
        const { settings } = request.route
        const { tags = [] } = settings
    Severity: Minor
    Found in server/plugins/navigation.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function register has 53 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

        register: (server) => {
      server.register([
        {
          plugin: require('hapi-proxy-get'),
          options: {
    Severity: Major
    Found in server/plugins/service-api-proxy.js - About 1 hr to fix

      Function handleGet has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        async handleGet (request, h, errors) {
    const { flow } = request.server.app
    const registration = await this.restoreRegistration(request)

    const owner = await Owner.get(request) || {}
      Severity: Minor
      Found in server/modules/check-your-answers/check-your-answers.handlers.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createServer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function createServer () {
  // Create the hapi server
  const server = hapi.server(serverOptions)

  // Add a reference to the server in the config
      Severity: Minor
      Found in server/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language