Sign upLogin

DRSchlaubi/regnum

View on GitHub
Star

Showing 9 of 19 total issues

RegnumJsonNode has 75 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("unused")
public class RegnumJsonNode extends JsonNode {

    final JsonNode jsonNode;
Severity: Major
Found in shared/src/main/java/cc/hawkbot/regnum/entities/json/RegnumJsonNode.java - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun <T> waitFor(eventClass: Class<T>, predicate: Predicate<T>, timeout: Long, timeoutUnit: TimeUnit): CompletionStage<T> {
        val future = CompletableFuture<T>()
        val listener = object : WaitingEventListener() {
            @EventSubscriber
            @Suppress("unused")
    Severity: Major
    Found in client/src/main/kotlin/cc/hawkbot/regnum/client/core/ClientEventWaiter.kt and 1 other location - About 7 hrs to fix
    server/src/main/kotlin/cc/hawkbot/regnum/server/core/internal/EventWaiterImpl.kt on lines 41..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 467.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun <T> waitFor(event: Class<T>, predicate: Predicate<T>, timeout: Long, timeoutUnit: TimeUnit): CompletionStage<T> {
        val future = CompletableFuture<T>()
        val listener = object : WaitingEventListener() {
            @SubscribeEvent
            @Suppress("unused")
    Severity: Major
    Found in server/src/main/kotlin/cc/hawkbot/regnum/server/core/internal/EventWaiterImpl.kt and 1 other location - About 7 hrs to fix
    client/src/main/kotlin/cc/hawkbot/regnum/client/core/ClientEventWaiter.kt on lines 39..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 467.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    JsonArray has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @SuppressWarnings({"unused", "WeakerAccess"})
public class JsonArray extends RegnumJsonNode {

    private static final String EMPTY_ARRAY = "[]";
    Severity: Minor
    Found in shared/src/main/java/cc/hawkbot/regnum/entities/json/JsonArray.java - About 4 hrs to fix

      JsonObject has 33 methods (exceeds 20 allowed). Consider refactoring.
      Open

      @SuppressWarnings("unused")
public class JsonObject extends RegnumJsonNode {

    private static final String EMPTY_OBJECT = "{}";
      Severity: Minor
      Found in shared/src/main/java/cc/hawkbot/regnum/entities/json/JsonObject.java - About 4 hrs to fix

        File RegnumJsonNode.java has 320 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
 * Regnum - A Discord bot clustering system made for Hawk
 *
 * Copyright (C) 2019  Michael Rittmeister
 *
        Severity: Minor
        Found in shared/src/main/java/cc/hawkbot/regnum/entities/json/RegnumJsonNode.java - About 3 hrs to fix

          Method onEvent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public final void onEvent(@NotNull Object event) {
        if (event instanceof Event) {
            onGenericEvent((Event) event);
            if (event instanceof ReadyEvent) {
          Severity: Minor
          Found in client/src/main/java/cc/hawkbot/regnum/client/event/ListenerAdapter.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              override fun unregister(listener: Any) {
        if (listener !is EventListener) {
            throw IllegalArgumentException("Interfaced event manager only accepts EventListener implementing classes")
        }
        super.unregister(listener)
          Severity: Minor
          Found in client/src/main/kotlin/cc/hawkbot/regnum/client/event/impl/InterfacedEventManager.kt and 1 other location - About 50 mins to fix
          client/src/main/kotlin/cc/hawkbot/regnum/client/event/impl/InterfacedEventManager.kt on lines 37..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              override fun register(listener: Any) {
        if (listener !is EventListener) {
            throw IllegalArgumentException("Interfaced event manager only accepts EventListener implementing classes")
        }
        super.register(listener)
          Severity: Minor
          Found in client/src/main/kotlin/cc/hawkbot/regnum/client/event/impl/InterfacedEventManager.kt and 1 other location - About 50 mins to fix
          client/src/main/kotlin/cc/hawkbot/regnum/client/event/impl/InterfacedEventManager.kt on lines 44..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language