Sign upLogin

DaSourcerer/yii2-yiiboard

View on GitHub
Star
controllers/MessageController.php

Summary

Maintainability
C
1 day
Test Coverage

Function actionCreate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionCreate()
    {
        if(!Yii::$app->user->can('app.forum.message.create'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
Severity: Minor
Found in controllers/MessageController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionCreate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionCreate()
    {
        if(!Yii::$app->user->can('app.forum.message.create'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
Severity: Minor
Found in controllers/MessageController.php - About 1 hr to fix

    Method actionSendReport has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionSendReport() {
        if(!Yii::$app->user->can('app.forum.message.send-report'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        $json = [];
    Severity: Minor
    Found in controllers/MessageController.php - About 1 hr to fix

      Function actionView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionView() {
        if(!Yii::$app->user->can('app.forum.message.view'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        $json = [];
      Severity: Minor
      Found in controllers/MessageController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if($model->save()) 
        {
            $json['success'] = 'yes';
            $json['message'] = YBoard::t('yboard', 'PM Sent Successfully');
        } else
      Severity: Major
      Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
      controllers/MessageController.php on lines 165..171
      controllers/MessageController.php on lines 240..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if($model->save()) {
                $json['success'] = 'yes';
                $json['message'] = YBoard::t('yboard', 'PM Sent Successfully');
            } else {
                $json['success'] = 'no';
      Severity: Major
      Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
      controllers/MessageController.php on lines 100..108
      controllers/MessageController.php on lines 240..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if($model->save()) {
                $json['success'] = 'yes';
                $json['message'] = YBoard::t('yboard', 'Thank you for your report.');
            } else {
                $json['success'] = 'no';
      Severity: Major
      Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
      controllers/MessageController.php on lines 100..108
      controllers/MessageController.php on lines 165..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status