Sign upLogin

DaSourcerer/yii2-yiiboard

View on GitHub
Star
controllers/ModeratorController.php

Summary

Maintainability
F
4 days
Test Coverage

File ModeratorController.php has 430 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace app\modules\yboard\controllers;

use app\modules\yboard\YBoard;
Severity: Minor
Found in controllers/ModeratorController.php - About 6 hrs to fix

    Function actionChangeTopic has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionChangeTopic()
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
    Severity: Minor
    Found in controllers/ModeratorController.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actionChangeTopic has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionChangeTopic()
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
    Severity: Major
    Found in controllers/ModeratorController.php - About 2 hrs to fix

      Method actionDelete has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionDelete($id) {
        if(!Yii::$app->user->can('app.forum.moderator.delete-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        if(isset($_GET['id']))
      Severity: Minor
      Found in controllers/ModeratorController.php - About 1 hr to fix

        Function actionDelete has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionDelete($id) {
        if(!Yii::$app->user->can('app.forum.moderator.delete-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        if(isset($_GET['id']))
        Severity: Minor
        Found in controllers/ModeratorController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method actionTopic has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function actionTopic() {
        if(!Yii::$app->user->can('app.forum.moderator.topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        $json = [];
        Severity: Minor
        Found in controllers/ModeratorController.php - About 1 hr to fix

          Function actionChangeBanPeriod has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function actionChangeBanPeriod($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-ban-period'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
          Severity: Minor
          Found in controllers/ModeratorController.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method actionChangePost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function actionChangePost()
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
          Severity: Minor
          Found in controllers/ModeratorController.php - About 1 hr to fix

            Method actionApprovePost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function actionApprovePost($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
            Severity: Minor
            Found in controllers/ModeratorController.php - About 1 hr to fix

              Method actionChangeBanPeriod has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function actionChangeBanPeriod($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-ban-period'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
              Severity: Minor
              Found in controllers/ModeratorController.php - About 1 hr to fix

                Method actionApproveTopic has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function actionApproveTopic($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                Severity: Minor
                Found in controllers/ModeratorController.php - About 1 hr to fix

                  Function actionTopic has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionTopic() {
        if(!Yii::$app->user->can('app.forum.moderator.topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        
        $json = [];
                  Severity: Minor
                  Found in controllers/ModeratorController.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionApprovePost has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionApprovePost($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Minor
                  Found in controllers/ModeratorController.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionApproveTopic has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionApproveTopic($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Minor
                  Found in controllers/ModeratorController.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionChangePost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionChangePost()
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Minor
                  Found in controllers/ModeratorController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function actionApproveTopic($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Major
                  Found in controllers/ModeratorController.php and 1 other location - About 6 hrs to fix
                  controllers/ModeratorController.php on lines 112..142

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 220.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function actionApprovePost($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Major
                  Found in controllers/ModeratorController.php and 1 other location - About 6 hrs to fix
                  controllers/ModeratorController.php on lines 78..108

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 220.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function actionBans()
    {
        if(!Yii::$app->user->can('app.forum.moderator.bans'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
                  Severity: Minor
                  Found in controllers/ModeratorController.php and 1 other location - About 45 mins to fix
                  controllers/SettingController.php on lines 457..468

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 96.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status