Sign upLogin

DaSourcerer/yii2-yiiboard

View on GitHub
Star

Showing 153 of 153 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if($model->save()) 
        {
            $json['success'] = 'yes';
            $json['message'] = YBoard::t('yboard', 'PM Sent Successfully');
        } else
Severity: Major
Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
controllers/MessageController.php on lines 165..171
controllers/MessageController.php on lines 240..246

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if($model->save()) {
                $json['success'] = 'yes';
                $json['message'] = YBoard::t('yboard', 'PM Sent Successfully');
            } else {
                $json['success'] = 'no';
Severity: Major
Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
controllers/MessageController.php on lines 100..108
controllers/MessageController.php on lines 240..246

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                [
                                    'label' => YBoard::t('yboard','Delete post').' <span class="glyphicon glyphicon-trash"></span>', 
                                    'url' => '/',
                                    'options'=>[
                                        //'class'=>'btn btn-danger btn-sm',
Severity: Major
Found in views/forum/_post.php and 1 other location - About 1 hr to fix
views/forum/_post.php on lines 236..245

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                [
                                    'label' => YBoard::t('yboard','Disapprove post').' <span class="glyphicon glyphicon-remove-circle"></span>', 
                                    'url' => '#',
                                    'options'=>[
                                        //'class'=>'btn btn-danger btn-sm',
Severity: Major
Found in views/forum/_post.php and 1 other location - About 1 hr to fix
views/forum/_post.php on lines 224..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if($model->save()) {
                $json['success'] = 'yes';
                $json['message'] = YBoard::t('yboard', 'Thank you for your report.');
            } else {
                $json['success'] = 'no';
Severity: Major
Found in controllers/MessageController.php and 2 other locations - About 1 hr to fix
controllers/MessageController.php on lines 100..108
controllers/MessageController.php on lines 165..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method resetLastPost has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function resetLastPost() { 
        $forum = YBoardForum::find()->where(['last_post_id'=>$this->id])->one();
        $topic = YBoardTopic::find()->where(['last_post_id'=>$this->id])->one();

        if($forum !== null) {
Severity: Minor
Found in models/YBoardPost.php - About 1 hr to fix

    Function actionChangeBanPeriod has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionChangeBanPeriod($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-ban-period'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
    Severity: Minor
    Found in controllers/ModeratorController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actionUpdatePoll has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionUpdatePoll($id) {
        $poll = YBoardPoll::findOne($id);
        if($poll === null) {
            throw new NotFoundHttpException(YBoard::t('yboard', 'The requested poll does not exist.'));
        }
    Severity: Minor
    Found in controllers/ForumController.php - About 1 hr to fix

      Method actionChangePost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionChangePost()
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
      Severity: Minor
      Found in controllers/ModeratorController.php - About 1 hr to fix

        Method actionApprovePost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function actionApprovePost($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-post'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
        Severity: Minor
        Found in controllers/ModeratorController.php - About 1 hr to fix

          Method getForumOptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function getForumOptions($isGuest, $uid) {
        $return = []; 
        $category = YBoardForum::find()
                    ->where(['type'=>0])
                    ->orderBy('sort')
          Severity: Minor
          Found in models/YBoardForum.php - About 1 hr to fix

            Method actionChangeBanPeriod has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function actionChangeBanPeriod($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.change-ban-period'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
            Severity: Minor
            Found in controllers/ModeratorController.php - About 1 hr to fix

              Method actionApproveTopic has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function actionApproveTopic($id)
    {
        if(!Yii::$app->user->can('app.forum.moderator.approve-topic'))
            throw new ForbiddenHttpException(YBoard::t('yboard', 'You have no enough permission to access this page! If you think its a mistake, please consider reporting to us.'));
              Severity: Minor
              Found in controllers/ModeratorController.php - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if($post->approved) {
                    $forum->updateCounters(['num_posts'=>1]);                    
                    $topic->updateCounters(['num_replies'=>1]);
                                        
                    $topic->updateAttributes(['last_post_id'=>$post->id]);
                Severity: Major
                Found in controllers/ForumController.php and 1 other location - About 1 hr to fix
                controllers/ForumController.php on lines 477..487

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if($post->approved) {
                    $forum->updateCounters(['num_posts'=>1]);
                    
                    $topic->updateCounters(['num_replies'=>1]);
                Severity: Major
                Found in controllers/ForumController.php and 1 other location - About 1 hr to fix
                controllers/ForumController.php on lines 720..728

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if($forum !== null) { 
            $post = YBoardPost::find()
            ->where(['forum_id'=>$forum->id, 'approved'=>1])
            ->orderBy('id DESC')
            ->limit(1)
                Severity: Major
                Found in models/YBoardPost.php and 1 other location - About 1 hr to fix
                models/YBoardPost.php on lines 247..260

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if($topic !== null) {
            $post = YBoardPost::find()
            ->where(['topic_id'=>$topic->id, 'approved'=>1])
            ->orderBy('id DESC')
            ->limit(1)
                Severity: Major
                Found in models/YBoardPost.php and 1 other location - About 1 hr to fix
                models/YBoardPost.php on lines 232..245

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.post(url, formdata, function(data) {
        if(data.success == 'yes') {
            $("#poll").html(data.html);
        }
    }, 'json');
                Severity: Minor
                Found in assets/js/yboard.js and 1 other location - About 55 mins to fix
                assets/js/yboard.js on lines 228..232

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    $.post(url, formdata, function(data) {
        if(data.success == 'yes') {
            $("#poll").html(data.html);
        }
    }, 'json');
                Severity: Minor
                Found in assets/js/yboard.js and 1 other location - About 55 mins to fix
                assets/js/yboard.js on lines 237..241

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function topicIsRead has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function topicIsRead($topic_id) {
        if(Yii::$app->user->isGuest) {
            return false;
        } else {
            $topicLog = YBoardLogTopic::findOne(['member_id'=>Yii::$app->user->id, 'topic_id'=>$topic_id]);
                Severity: Minor
                Found in controllers/ForumController.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language