Sign upLogin

Dallinger/Dallinger

View on GitHub
Star

Showing 1,036 of 1,036 total issues

Function build has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def build(root):
    if not os.path.exists(os.path.join(root, "demos")):
        os.makedirs(os.path.join(root, "demos"))

    demos_dir = os.path.abspath(
Severity: Minor
Found in docs/source/build_demo_docs.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fail has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def fail(self, reason=None):
        """Fail this object, and potentially its related objects.

        Set :attr:`~dallinger.models.SharedMixin.failed` to ``True`` and
        :attr:`~dallinger.models.SharedMixin.time_of_death` to now.
Severity: Minor
Found in dallinger/models.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pg_wait has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def pg_wait(self):
        """Wait for the DB to be fired up."""
        retries = 10
        while retries:
            retries = retries - 1
Severity: Minor
Found in dallinger/heroku/tools.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function expunge_directory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def expunge_directory(path_string):
    """Remove all content from a directory."""
    for filepath in Path(path_string).iterdir():
        try:
            if filepath.is_file() or filepath.is_symlink():
Severity: Minor
Found in dallinger/utils.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function as_dict has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def as_dict(self, include_sensitive=False):
        d = {}
        for key in self.types:
            if key not in self.sensitive or include_sensitive:
                try:
Severity: Minor
Found in dallinger/config.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            try:
                result = requests.post(url)
                result.raise_for_status()
            except RequestException:
                self.stochastic_sleep()
Severity: Minor
Found in dallinger/bots.py and 1 other location - About 35 mins to fix
dallinger/bots.py on lines 308..313

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            try:
                result = requests.get(url)
                result.raise_for_status()
            except RequestException:
                self.stochastic_sleep()
Severity: Minor
Found in dallinger/bots.py and 1 other location - About 35 mins to fix
dallinger/bots.py on lines 275..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

            return error_response(
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return error_response(
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return error_response(error_type=msg)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return success_response()
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return success_response(recruitment_msg=message)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return error_response(error_type=msg)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return error_response(
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return error_response(error_type="/question POST server error", status=403)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return success_response(transmissions=[t.__json__() for t in transmissions])
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return error_response(error_type=msg)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return error_response(
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return success_response(**result)
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return success_response(info=info.__json__())
Severity: Major
Found in dallinger/experiment_server/experiment_server.py - About 30 mins to fix
Severity
Category
Status
Source
Language