Sign upLogin

Dalphi/dalphi

View on GitHub
Star
app/controllers/api/v1/base_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Line is too long. [88/80]
Open

                 message: I18n.t('api.statistic.general-errors.parameter-type-mismatch')
Severity: Minor
Found in app/controllers/api/v1/base_controller.rb by rubocop

Redundant return detected.
Open

          return render status: :unauthorized,
Severity: Minor
Found in app/controllers/api/v1/base_controller.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Do not introduce global variables.
Open

           $redis.hdel(:auth_token, params['auth_token']) != 1
Severity: Minor
Found in app/controllers/api/v1/base_controller.rb by rubocop

This cops looks for uses of global variables. It does not report offenses for built-in global variables. Built-in global variables are allowed by default. Additionally users can allow additional variables via the AllowedVariables option.

Note that backreferences like $1, $2, etc are not global variables.

Example:

# bad
$foo = 2
bar = $foo + 5

# good
FOO = 2
foo = 2
$stdin.read

Missing top-level class documentation comment.
Open

    class BaseController < ActionController::Base
Severity: Minor
Found in app/controllers/api/v1/base_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status