Sign upLogin

Dalphi/dalphi

View on GitHub
Star

Showing 1,441 of 1,441 total issues

Line is too long. [84/80]
Open

      key :description, I18n.t('api.annotation_document.description.interface_type')
Severity: Minor
Found in app/models/annotation_document.rb by rubocop

Line is too long. [94/80]
Open

    return integer_and_action_label(token, predecessor_token) if is_integer_and_action?(token)
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

Align .find with predecessor_token on line 82.
Open

              .find(integer)
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Rename is_integer_and_action? to integer_and_action?.
Open

  def is_integer_and_action?(integer_and_action)
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Line is too long. [84/80]
Open

      .gsub(/^http(|s):\/\/[^\/]+(|:[0-9]+)/, '') # remove protocol, domain and port
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

Rename is_action? to action?.
Open

  def is_action?(action)
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Keep a blank line before and after private.
Open

  private
Severity: Minor
Found in app/controllers/interface_types_controller.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Avoid using rescue in its modifier form.
Open

    model = predecessor_token
              .singularize
              .classify
              .constantize
              .find(integer)
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

This cop checks for uses of rescue in its modifier form.

Example:

# bad
some_method rescue handle_error

# good
begin
  some_method
rescue
  handle_error
end

Avoid using rescue in its modifier form.
Open

    klass.classify.constantize rescue false
Severity: Minor
Found in app/helpers/breadcrumb_bakery.rb by rubocop

This cop checks for uses of rescue in its modifier form.

Example:

# bad
some_method rescue handle_error

# good
begin
  some_method
rescue
  handle_error
end

Line is too long. [88/80]
Open

    # Never trust parameters from the scary internet, only allow the white list through.
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

Inconsistent indentation detected.
Open

    def set_available_services
      @available_services = {}
      @roles.each do |role|
        role_symbol = role.to_sym
        @available_services[role_symbol] = Service.where(role: role_symbol)
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def set_project
      @project = current_role.projects.find(params[:project_id])
    rescue
      render_annotation_document_errors 400, 'set-project.not-found'
    end
Severity: Minor
Found in app/controllers/annotation_documents_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def project_params
      params.require(:project).permit(
        :iterate_service,
        :data,
        :description,
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def redirect_iterate_with_flash
      flash[:error] = I18n.t('projects.iterate.error')
      redirect_to project_annotation_documents_path(@project)
    end
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Line is too long. [81/80]
Open

                                   process_iteration_data_response_hash(raw_data)
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

Avoid rescuing without specifying an error class.
Open

    rescue
Severity: Minor
Found in app/controllers/annotation_documents_controller.rb by rubocop

This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

Example: EnforcedStyle: implicit

# `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Example: EnforcedStyle: explicit (default)

# `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Missing top-level class documentation comment.
Open

    class BaseController < ActionController::Base
Severity: Minor
Found in app/controllers/api/v1/base_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def set_interface_type
      @interface_type = InterfaceType.find(params[:id])
    end
Severity: Minor
Found in app/controllers/interface_types_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Line is too long. [91/80]
Open

    render json: { associatedProblemIdentifiers: @project.associated_problem_identifiers },
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

Line is too long. [87/80]
Open

        new_params[service_symbol] = Service.find_by_id(project_params[service_symbol])
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop
Severity
Category
Status
Source
Language