Dalphi/dalphi

View on GitHub

Showing 1,441 of 1,441 total issues

Indent ) the same as the start of the line where ( is.
Open

                              )

This cops checks the indentation of hanging closing parentheses in method calls, method definitions, and grouped expressions. A hanging closing parenthesis means ) preceded by a line break.

Example:

# good: when x is on its own line, indent this way
func(
  x,
  y
)

# good: when x follows opening parenthesis, align parentheses
a = b * (x +
         y
        )

# bad
def func(
  x,
  y
  )
end

Line is too long. [83/80]
Open

            key :description, I18n.t('api.annotation_document.update.response-200')

Missing top-level class documentation comment.
Open

    class RawDataController < BaseController

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Keep a blank line before and after private.
Open

  private

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Inconsistent indentation detected.
Open

    def interface_params
      params.require(:interface).permit(
        :template,
        :java_script,
        :stylesheet,

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if interface_type_name

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [95/80]
Open

    error_message = I18n.t('activerecord.errors.models.service.attributes.url.badHttpResponse')

Extra empty line detected at class body beginning.
Open


  def initialize(_model)

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Missing top-level class documentation comment.
Open

class ApplicationMailer < ActionMailer::Base
Severity: Minor
Found in app/mailers/application_mailer.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing space after #.
Open

    #coverage.output_path = "coverage"
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [119/80]
Open

    # Specify the framework you would like to use. This allows you to select versions, and will do some basic setup for
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

Line is too long. [81/80]
Open

  # be run in the default suite -- but can be focused into a more specific suite.
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

Line is too long. [108/80]
Open

  # Specify which headless driver to use. Supports PhantomJS, Selenium Webdriver and BrowserStack Webdriver.
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    suite.body_partial = "body"
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

%w-literals should be delimited by [ and ].
Open

    elsif %w(machine_learning merge).include?(record.role) && record.interface_types.any?

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Line is too long. [100/80]
Open

      next if record.associated_problem_identifiers & interface.associated_problem_identifiers == []

Line is too long. [81/80]
Open

    raise 'wrong service' if target_service && target_service.role != type[0..-9]

Missing space after #.
Open

  #config.fail_fast = true
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Missing space after #.
Open

    #coverage.branches = nil
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [118/80]
Open

  # Fixtures are rendered through a controller, which allows using HAML, RABL/JBuilder, etc. Files in these paths will
Severity: Minor
Found in spec/teaspoon_env.rb by rubocop
Severity
Category
Status
Source
Language