Sign upLogin

Dalphi/dalphi

View on GitHub
Star

Showing 1,441 of 1,441 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      swagger_path '/annotation_documents/{id}' do
        operation :delete do
          key :comsumes, ['application/json']
          key :description, I18n.t('api.annotation_document.destroy.description')
          key :operationId, 'annotation_document_destroy'
Severity: Major
Found in app/controllers/api/v1/annotation_documents_controller.rb and 5 other locations - About 1 hr to fix
app/controllers/api/v1/annotation_documents_controller.rb on lines 14..40
app/controllers/api/v1/raw_data_controller.rb on lines 13..39
app/controllers/api/v1/raw_data_controller.rb on lines 167..193
app/controllers/api/v1/statistics_controller.rb on lines 13..39
app/controllers/api/v1/statistics_controller.rb on lines 121..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      swagger_path '/raw_data/{id}' do
        operation :get do
          key :comsumes, ['application/json']
          key :description, I18n.t('api.raw_datum.show.description')
          key :operationId, 'raw_datum_read'
Severity: Major
Found in app/controllers/api/v1/raw_data_controller.rb and 5 other locations - About 1 hr to fix
app/controllers/api/v1/annotation_documents_controller.rb on lines 14..40
app/controllers/api/v1/annotation_documents_controller.rb on lines 122..148
app/controllers/api/v1/raw_data_controller.rb on lines 167..193
app/controllers/api/v1/statistics_controller.rb on lines 13..39
app/controllers/api/v1/statistics_controller.rb on lines 121..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Block has too many lines. [43/25]
Open

  describe 'problem_id' do
    it 'may not be nil' do
      @merge_service.problem_id = nil
      expect(@merge_service).to be_invalid
    end
Severity: Minor
Found in spec/models/service_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [43/25]
Open

  describe 'necessary_interface_types' do
    it 'should be an empty array for a project with no associated services' do
      @project.iterate_service = nil

      expect(@project.necessary_interface_types).to eq([])
Severity: Minor
Found in spec/models/project_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method has too many lines. [11/10]
Open

  def iterate
    process_iteration_data(@project.iterate_data)
    if @annotation_documents
      save_statistics
      record_count, error_count = save_annotation_documents
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def relevant_attributes
    {
      id: id,
      interface_type: interface_type.name,
      meta: meta,
Severity: Minor
Found in app/models/annotation_document.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

    def save_annotation_documents
      record_count = error_count = 0
      @annotation_documents.each do |annotation_document|
        type_name = annotation_document['interface_type']
        interface_type = InterfaceType.find_or_create_by(name: type_name)
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for update is too high. [16.16/15]
Open

      def update
        params_data = params['data']
        if params_data.present?
          File.write @raw_datum.data.path,
                     Base64.decode64(params_data).force_encoding('utf-8')
Severity: Minor
Found in app/controllers/api/v1/raw_data_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [11/10]
Open

    def raw_data_zip
      timestamp = Time.zone.now.strftime('%Y-%m-%d-%H-%M-%S')
      begin
        file = Tempfile.new('raw-data-zip')
        send_data @project.zip(file),
Severity: Minor
Found in app/controllers/raw_data_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

      def update
        if @annotation_document.update(converted_annotation_document_params)
          render json: @annotation_document.relevant_attributes
        else
          render status: 400,
Severity: Minor
Found in app/controllers/api/v1/annotation_documents_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def self.validate_stylesheet(record)
    return if record.stylesheet.path.nil?

    container_class = Rails.configuration.x.dalphi['annotation-interface']['container-class-name']
    stylesheet_contents = Paperclip.io_adapters.for(record.stylesheet).read
Severity: Minor
Found in app/validators/website_components_validator.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

      def update
        if @statistic.update(statistic_params)
          render json: @statistic.relevant_attributes
        else
          render status: 400,
Severity: Minor
Found in app/controllers/api/v1/statistics_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def create
    data = raw_datum_params[:data]
    batch_result = RawDatum.batch_process @project,
                                          data
    if batch_result[:success].any?
Severity: Minor
Found in app/controllers/raw_data_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

    def converted_attributes
      new_params = interface_params
      associated_problems = interface_params['associated_problem_identifiers']
      if associated_problems
        new_params['associated_problem_identifiers'] = associated_problems.strip
Severity: Minor
Found in app/controllers/interfaces_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe 'version' do
    it 'should not be nil' do
      @merge_service.version = nil
      expect(@merge_service).to be_invalid
    end
Severity: Major
Found in spec/models/service_spec.rb and 1 other location - About 1 hr to fix
spec/models/interface_type_spec.rb on lines 89..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe 'test_payload' do
    it 'can be nil' do
      @interface_type.test_payload = nil
      expect(@interface_type).to be_valid
    end
Severity: Major
Found in spec/models/interface_type_spec.rb and 1 other location - About 1 hr to fix
spec/models/service_spec.rb on lines 238..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Block has too many lines. [42/25]
Open

  describe 'payload' do
    it 'should not be nil' do
      @annotation_document.payload = nil
      expect(@annotation_document).to be_invalid
    end
Severity: Minor
Found in spec/models/annotation_document_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [42/25]
Open

    it 'creates multiple raw_data for a list of valid raw_data' do
      project = FactoryGirl.create(:project)
      raw_datum_1 = FactoryGirl.build(:raw_datum, project: project)
      raw_datum_2 = FactoryGirl.build(:raw_datum, project: project)
      expect(RawDatum.count).to eq(0)
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Assignment Branch Condition size for batch_process is too high. [15.68/15]
Open

  def self.batch_process(project, data)
    return { error: [], success: [] } unless data || data == []
    data_size = data.size
    data_first = data.first.tempfile
    if data_size == 1 && valid_zip?(data_first)
Severity: Minor
Found in app/models/raw_datum.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Block has too many lines. [41/25]
Open

  describe 'interface types' do
    it { should have_and_belong_to_many(:interface_types) }

    it 'can be empty for machine learning services' do
      @ml_service.interface_types.clear
Severity: Minor
Found in spec/models/service_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Severity
Category
Status
Source
Language