Sign upLogin

Dalphi/dalphi

View on GitHub
Star
spec/requests/projects/annotation_documents/destroy_all_spec.rb

Summary

Maintainability
A
45 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it 'destroys all annotation documents from a project' do
    expect(AnnotationDocument.count).to eq(2)

    delete project_annotation_documents_path(@project),
           params: {
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb and 1 other location - About 45 mins to fix
spec/requests/projects/raw_data/destroy_all_spec.rb on lines 13..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [106/80]
Open

    expect(response.header['Location'].gsub(/\?.*/, '')).to eq(project_annotation_documents_url(@project))
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb by rubocop

Use normalcase for variable numbers.
Open

    @annotation_document_2 = FactoryGirl.create :annotation_document_with_different_payload,
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Use normalcase for variable numbers.
Open

    @annotation_document_1 = FactoryGirl.create :annotation_document,
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Line is too long. [102/80]
Open

                                                interface_type: @annotation_document_1.interface_type,
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb by rubocop

Line is too long. [92/80]
Open

    @annotation_document_2 = FactoryGirl.create :annotation_document_with_different_payload,
Severity: Minor
Found in spec/requests/projects/annotation_documents/destroy_all_spec.rb by rubocop

There are no issues that match your filters.

Category
Status