Sign upLogin

DanielSchuech/ngAdapter

View on GitHub
Star

Showing 6 of 6 total issues

Function exports has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config) {
  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '.',
Severity: Major
Found in karma.conf.js - About 2 hrs to fix

    Function createDirective has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      createDirective(selector: string, fn: Function, deps: string[]) {
    //evaluate bindings
    let bindings = Object.keys(fn().scope || {});
    
    //evaluate events
    Severity: Minor
    Found in src/upgrade.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        $on(name: string, listener: Function) {
    if (!this.events[name]) {
      this.events[name] = new EventEmitter<any>();
    }
      Severity: Major
      Found in src/scopeevents.ts and 1 other location - About 1 hr to fix
      src/scopeevents.ts on lines 7..13

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        $broadcast(name: string, args: any) {
    if (!this.events[name]) {
      this.events[name] = new EventEmitter<any>();
    }
      Severity: Major
      Found in src/scopeevents.ts and 1 other location - About 1 hr to fix
      src/scopeevents.ts on lines 19..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function searchDirective has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        searchDirective(directive:string, module: angular.IModule): Function|Array<any> {
    /**
     * invokeQueue contains all actions on angular.module
     * including controller, directive & service declarations
     */
      Severity: Minor
      Found in src/upgrade.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function downgradeNg2Module has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        downgradeNg2Module(mod: Type<any>) {
    let ng1Module = angular.module((<any>mod).name, []);
    let meta = Reflect.getOwnMetadata('annotations', mod)[0];
    meta.exports && meta.exports.forEach((item: Type<any>) => {
      let type = Reflect.getOwnMetadata('annotations', item)[0];
      Severity: Minor
      Found in src/ngAdapter.ts - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language