DannyBen/snapcrawl

View on GitHub

Showing 5 of 5 total issues

Method register_sub_pages has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def register_sub_pages(pages)
      pages.each do |sub_page|
        next if todo.has_key?(sub_page) || done.include?(sub_page)

        if Config.url_whitelist && sub_page.path !~ (/#{Config.url_whitelist}/)
Severity: Minor
Found in lib/snapcrawl/crawler.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return nil unless link.include? site
Severity: Major
Found in lib/snapcrawl/page.rb - About 30 mins to fix

    Method load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def load(file = nil)
            reset!
            push defaults
    
            return unless file
    Severity: Minor
    Found in lib/snapcrawl/config.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pair_split has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def pair_split
            false_values = %w[no false]
            true_values = %w[yes true]
    
            to_h do |pair|
    Severity: Minor
    Found in lib/snapcrawl/refinements/pair_split.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalize_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def normalize_link(link)
          link = link.attribute('href').to_s.dup
    
          # Remove #hash
          link.gsub!(/#.+$/, '')
    Severity: Minor
    Found in lib/snapcrawl/page.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language