DaoCasino/bankroller-core

View on GitHub

Showing 397 of 397 total issues

File DApp.js has 546 lines of code (exceeds 500 allowed). Consider refactoring.
Open

import _config         from 'config'
import path            from 'path'
import * as messaging  from 'dc-messaging'
import PQueue          from 'p-queue'
import Eth             from 'Eth'
Severity: Major
Found in lib/dapps/DApp.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          const state_hash = Utils.sha3(
            {t: 'bytes32' , v: state_data._id                }   ,
            {t: 'uint'    , v: state_data._playerBalance     }   ,
            {t: 'uint'    , v: state_data._bankrollerBalance }   ,
            {t: 'uint'    , v: state_data._totalBet          }   ,
    Severity: Major
    Found in lib/dapps/DApp.js and 1 other location - About 2 hrs to fix
    lib/dapps/DApp.js on lines 130..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          const player_state_hash = Utils.sha3(
            {t: 'bytes32', v: state_data._id                },
            {t: 'uint',    v: state_data._playerBalance     },
            {t: 'uint',    v: state_data._bankrollerBalance },
            {t: 'uint',    v: state_data._totalBet          },
    Severity: Major
    Found in lib/dapps/DApp.js and 1 other location - About 2 hrs to fix
    lib/dapps/DApp.js on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    if (!fs.existsSync(filpath)) {
      console.log('')
      console.log('')
      console.log('Cant find contracts_adressess ', filpath)
      console.log('')
    Severity: Major
    Found in configs/local/config.js and 1 other location - About 2 hrs to fix
    configs/sdk/config.js on lines 5..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    if (!fs.existsSync(filpath)) {
      console.log('')
      console.log('')
      console.log('Cant find contracts_adressess ', filpath)
      console.log('')
    Severity: Major
    Found in configs/sdk/config.js and 1 other location - About 2 hrs to fix
    configs/local/config.js on lines 5..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        it('DCLib.Eth.getEthBalance(address)', function () {
    
            const address = JSON.parse(localStorage.web3wallet).address
            const getEthBalance = DCLib.Eth.getEthBalance(address)
            console.groupCollapsed('Eth balance')
    Severity: Major
    Found in data/dapps/dicespec/tests/EthHelpers/test.js and 2 other locations - About 2 hrs to fix
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 5..13
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 25..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        it('DCLib.Eth.getBalances(address)', function () {
    
            const address = JSON.parse(localStorage.web3wallet).address
            const getBalances = DCLib.Eth.getBalances(address)
            console.groupCollapsed('All balance')
    Severity: Major
    Found in data/dapps/dicespec/tests/EthHelpers/test.js and 2 other locations - About 2 hrs to fix
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 15..23
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 25..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        it('DCLib.Eth.getBetBalace(address)', function () {
    
            const address = JSON.parse(localStorage.web3wallet).address
            const getBetBalance = DCLib.Eth.getBetBalance(address)
            console.groupCollapsed('Bet balance')
    Severity: Major
    Found in data/dapps/dicespec/tests/EthHelpers/test.js and 2 other locations - About 2 hrs to fix
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 5..13
    data/dapps/dicespec/tests/EthHelpers/test.js on lines 15..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    function getGameContract (callback) {
      fetch('http://127.0.0.1:8181/?get=contract&name=Dice').then(function (res) {
        return res.json()
      }).then(function (localGameContract) {
        callback({
    Severity: Major
    Found in data/dapps/dicespec/public/bankroller.js and 1 other location - About 2 hrs to fix
    data/dapps/dicespec/public/test.js on lines 11..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const getDAppContract = function (callback) {
      fetch('http://127.0.0.1:8181/?get=contract&name=Dice').then(function (res) {
        return res.json()
      }).then(function (localGameContract) {
        callback({
    Severity: Major
    Found in data/dapps/dicespec/public/test.js and 1 other location - About 2 hrs to fix
    data/dapps/dicespec/public/bankroller.js on lines 3..12

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _call has a Cognitive Complexity of 27 (exceeds 15 allowed). Consider refactoring.
    Open

      async _call (data) {
        const user = this.users[data.user_id]
        if (!data.data || !data.data.gamedata || !data.data.seed) return
        if (!data.func || !data.func.name || !data.func.args) return
    
    
    Severity: Minor
    Found in lib/dapps/DApp.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('Unlock account with password', function () {
            this.timeout(3000)
            const unlock = DCLib.Account.unlockAccount('1234')
            console.groupCollapsed('Account info from unlock with password')
            console.table(unlock)
    Severity: Major
    Found in data/dapps/dicespec/tests/Account/test.js and 1 other location - About 2 hrs to fix
    data/dapps/dicespec/tests/Account/test.js on lines 49..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('Sign message', function () {
            this.timeout(3000)
            const sign = DCLib.Account.sign('Hello world')
            console.groupCollapsed('Sign message info')
            console.table(sign)
    Severity: Major
    Found in data/dapps/dicespec/tests/Account/test.js and 1 other location - About 2 hrs to fix
    data/dapps/dicespec/tests/Account/test.js on lines 7..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('Getting account information', function () {
            this.timeout(3000)
            const get = DCLib.Account.get()
            console.groupCollapsed('Account info from get function')
            console.table(get)
    Severity: Major
    Found in data/dapps/dicespec/tests/Account/test.js and 1 other location - About 1 hr to fix
    data/dapps/dicespec/tests/Account/test.js on lines 15..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('Unlock account without password', function () {
            this.timeout(3000)
            const unlock = DCLib.Account.unlockAccount()
            console.groupCollapsed('Account info from unlock without password')
            console.table(unlock)
    Severity: Major
    Found in data/dapps/dicespec/tests/Account/test.js and 1 other location - About 1 hr to fix
    data/dapps/dicespec/tests/Account/test.js on lines 39..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _call has 120 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

      async _call (data) {
        const user = this.users[data.user_id]
        if (!data.data || !data.data.gamedata || !data.data.seed) return
        if (!data.func || !data.func.name || !data.func.args) return
    
    
    Severity: Major
    Found in lib/dapps/DApp.js - About 1 hr to fix

      Function _newUser has a Cognitive Complexity of 21 (exceeds 15 allowed). Consider refactoring.
      Open

        async _newUser (params) {
          const connection_id = Utils.makeSeed()
          const user_id       = params.user_id
      
          if (this.users[user_id]) delete this.users[user_id]
      Severity: Minor
      Found in lib/dapps/DApp.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function channelState has 104 lines of code (exceeds 100 allowed). Consider refactoring.
      Open

      const channelState = function (player_openkey = false) {
        if (!player_openkey) {
          console.error(' player_openkey required in channelState constructor')
          return
        }
      Severity: Major
      Found in lib/dapps/DApp.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              it('Sign Hash string', function () {
                this.timeout(3000)
                const signHash = DCLib.Account.signHash('0xA9312KJD')
                console.log('Sign hash info: ', signHash)
              })
        Severity: Major
        Found in data/dapps/dicespec/tests/Account/test.js and 1 other location - About 1 hr to fix
        data/dapps/dicespec/tests/Account/test.js on lines 25..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            getBankrollerSigned (hash = false) {
              if (!hash) hash = Object.keys(states).splice(-1)
              return GetState(hash).bankroller
            }
        Severity: Major
        Found in lib/dapps/DApp.js and 1 other location - About 1 hr to fix
        lib/dapps/DApp.js on lines 188..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language