Showing 7 of 7 total issues
Method send_update_to_datadog has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def send_update_to_datadog(dog)
tags = combined_host_tags
retries = @retries
rc = []
begin- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method send_update_to_datadog has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def send_update_to_datadog(dog)
tags = combined_host_tags
retries = @retries
rc = []
beginMethod emit_to_datadog has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def emit_to_datadog(dog)
# Send base success/failure metric
dog.emit_point('chef.run.success', @run_status.success? ? 1 : 0, host: @hostname, type: 'counter')
dog.emit_point('chef.run.failure', @run_status.success? ? 0 : 1, host: @hostname, type: 'counter')
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_event_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def build_event_data
# bail early in case of a compiletime failure
# OPTIMIZE: Use better inspectors to handle failure scenarios, refactor needed.
if compile_error?
@alert_type = 'error'- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_keys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def validate_keys(api_key, app_key, should_fail)
if api_key.nil?
Chef::Log.warn('You need an API key to communicate with Datadog')
fail ArgumentError, 'Missing Datadog Api Key' if should_fail
return false- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method resolve_correct_hostname has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def resolve_correct_hostname
node = run_status.node
use_ec2_instance_id = !config.key?(:use_ec2_instance_id) ||
(config.key?(:use_ec2_instance_id) && config[:use_ec2_instance_id])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method node_policy_tags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def node_policy_tags
policy_tags = []
if @policy_tags_enabled
if @node.respond_to?('policy_group') && !@node.policy_group.nil?
policy_tags << "#{@scope_prefix}policy_group:#{@node.policy_group}"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"